Bug 422422

Summary: [Insert as Reference Image] Krita *.kra files not allowed
Product: [Applications] krita Reporter: David REVOY <info>
Component: Tools/Reference ImagesAssignee: Halla Rempt <halla>
Status: RESOLVED FIXED    
Severity: grave CC: anna.medonosova, halla
Priority: NOR Keywords: regression, triaged
Version First Reported In: 4.3.0-beta2   
Target Milestone: ---   
Platform: Appimage   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description David REVOY 2020-06-03 13:49:55 UTC
Hi,

To reproduce:
=============
1. Open an artwork
2. Drag'n'Drop a Krita *.kra file from the filemanager over the canvas
3. On the contextual menu: select "Insert as Reference Image"

Result:
=======
A pop-up dialog with a red speechbubble icon and a white X cross on it tells: "Could not load /path/to/the/kritafile.kra" [OK]

Expected:
=========
Getting the Krita file (the flat projection of the picture) inserted as a reference. 

Note:
=====
This feature is very useful to me when I compare a comic pages (eg.with the previous and next page side by side to adjust colors). I'll switch back to 4.2.9 to do this task, it works there; so it is probably a regression of 4.3.
Comment 1 Anna Medonosova 2020-06-03 20:48:50 UTC
I can confirm this; also in 4.3.0-beta1 and git master.
Comment 2 Halla Rempt 2020-06-11 11:13:42 UTC
This should be fixed in the next nightly.
Comment 3 Halla Rempt 2020-06-13 09:14:04 UTC
Hm, this was built correctly now, but it still doesn't work, I need to look into it again.
Comment 4 Halla Rempt 2020-06-15 10:25:48 UTC
Git commit 6dc11002251bd3f12bf42d436ee4e9246a4784fb by Boudewijn Rempt.
Committed on 15/06/2020 at 10:23.
Pushed by rempt into branch 'master'.

Try really hard to load reference image files

Sometimes Qt just refuses to use the .kra or .ora qimageio plugin,
for unknown reasons, even if they are present, so fall back on our
own image loading code.

M  +24   -3    libs/ui/KisReferenceImage.cpp

https://invent.kde.org/graphics/krita/commit/6dc11002251bd3f12bf42d436ee4e9246a4784fb
Comment 5 Halla Rempt 2020-06-15 10:27:29 UTC
Git commit cc9e0e4eee94642fcef5da8985fe91b89a3ac8d5 by Boudewijn Rempt.
Committed on 15/06/2020 at 10:24.
Pushed by rempt into branch 'krita/4.3.0'.

Try really hard to load reference image files

Sometimes Qt just refuses to use the .kra or .ora qimageio plugin,
for unknown reasons, even if they are present, so fall back on our
own image loading code.
(cherry picked from commit 6dc11002251bd3f12bf42d436ee4e9246a4784fb)

M  +24   -3    libs/ui/KisReferenceImage.cpp

https://invent.kde.org/graphics/krita/commit/cc9e0e4eee94642fcef5da8985fe91b89a3ac8d5
Comment 6 Halla Rempt 2020-06-15 12:31:29 UTC
Git commit 286dbbd1e6dd742cd16fc479ac151e67be384ba0 by Boudewijn Rempt.
Committed on 15/06/2020 at 11:59.
Pushed by rempt into branch 'krita/4.3'.

Try really hard to load reference image files

Sometimes Qt just refuses to use the .kra or .ora qimageio plugin,
for unknown reasons, even if they are present, so fall back on our
own image loading code.
(cherry picked from commit 6dc11002251bd3f12bf42d436ee4e9246a4784fb)

M  +24   -3    libs/ui/KisReferenceImage.cpp

https://invent.kde.org/graphics/krita/commit/286dbbd1e6dd742cd16fc479ac151e67be384ba0