Bug 422419

Summary: Pressing X to close Configure Krita dialogue saves settings instead of cancelling the changes
Product: [Applications] krita Reporter: Tyson Tan <tysontanx>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED INTENTIONAL    
Severity: normal CC: griffinvalley, halla, tamtamy.tymona
Priority: NOR    
Version: 4.3.0-beta2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:

Description Tyson Tan 2020-06-03 13:37:36 UTC 
Menu --> Settings --> Configure Krita

The settings are automatically saved when pressing the "X" button on top-right of the dialogue. Is this an intended feature or a bug? It's causing some confusion in the community.

Tested on 4.3.0 beta 2.
Comment 1 wolthera 2020-06-03 13:39:11 UTC 
considering the x button doesn't even exist on certain platforms, I guess we never really paid attention to it.
Comment 2 Tiar 2020-06-03 13:44:25 UTC 
It is intended, because people on Windows fullHD screens with 150% scaling couldn't figure out how to disable HighDPI scaling, because the OK button was not visible on their screens, because the configuration dialog was too big (note that in such case there is only ~700 pixels of space). That was Boud's decision afaik.

I guess we might want to revisit that after making the configuration dialog smaller/compact/resizeable.

Afaik pressing "Cancel" does cancel the changes though.
Comment 3 Tyson Tan 2020-06-03 13:48:45 UTC 
Yeah, that's what I guessed too, since we mentioned something like that in the documentation. Probably the FAQ. I will tell them about this. Please close the bug if needed. Thank you for the explanation.
Comment 4 Halla Rempt 2020-06-03 13:54:09 UTC 
Yes, it's intentional.