| Summary: | org.kde.plasmashell Internal Server Error | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kuserfeedback | Reporter: | Andres Betts <anditosan1000> |
| Component: | Management and Analytics Console | Assignee: | Volker Krause <vkrause> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/libraries/kuserfeedback/commit/f22b81e8273ddbd79ff249f2f06bbc87bf5074d4 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Andres Betts
2020-05-29 13:49:12 UTC
*** Bug 422348 has been marked as a duplicate of this bug. *** Plasma and Discover show this problem, all other products seems to work fine. Asking sysadmins for the server logs. Ben checked the logs, the problem seems to be that the server hits the PHP memory limit for those two products (as they have accumulated 10+M of data by now), and right now the full JSON response with that data is assembled in memory. A possibly relevant merge request was started @ https://invent.kde.org/libraries/kuserfeedback/-/merge_requests/4 Git commit f22b81e8273ddbd79ff249f2f06bbc87bf5074d4 by David Edmundson. Committed on 21/08/2020 at 08:42. Pushed by davidedmundson into branch 'master'. [server] Convert JSON fetch to stream data Currently the code builds up all the data in a massive blob then tries to encode the JSON. This hits a memory limit on our server for popular products. By fetching and printing one piece of information at a time we should avoid this. Fetching scalar and non-scalar information now needed to be put together so we fetch non-scalar information on a per-row basis. Technically more queries, but it saves hash look ups our side. Tested against the submittest unit test. I haven't tested with "real" data. M +1 -1 src/server/shared/analytics.php M +40 -44 src/server/shared/sample.php https://invent.kde.org/libraries/kuserfeedback/commit/f22b81e8273ddbd79ff249f2f06bbc87bf5074d4 |