Bug 422146

Summary:	Konversation allows spaces in nicks and username/ident in the config, which breaks USER
Product:	[Applications] konversation	Reporter:	Christian (Fuchs) <kde>
Component:	general	Assignee:	Konversation Bugs <konversation-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	Git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/network/konversation/commit/47733e88b76822f61cd9fcc6ff0434ebf6223823	Version Fixed/Implemented In:
Sentry Crash Report:

Description Christian (Fuchs) 2020-05-27 19:43:31 UTC

SUMMARY
As someone accidentally found out in #konversation: apparently konversation allows spaces in both nick and ident/username configuration in the identity, which leads to a broken USER command sent, like 

USER I haveASpace! 8 * :my gecos%0A

which shifts around parameters, so * is taken as the GECOS/Realname

STEPS TO REPRODUCE
1. Open the identify configuration
2. Add a nick and/or ident which contains a space
3. Connect

OBSERVED RESULT

Broken USER command sent

EXPECTED RESULT

Spaces should be, if possible, already disallowed in the GUI config and, additionally, be trimmed before sent.

SOFTWARE/OS VERSIONS
Any


ADDITIONAL INFORMATION
Not affected myself, just reporting it for documentation purposes

Comment 1 Bug Janitor Service 2020-12-29 09:19:55 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/konversation/-/merge_requests/40

Comment 2 Peter Simonsson 2020-12-31 06:34:41 UTC

Git commit 47733e88b76822f61cd9fcc6ff0434ebf6223823 by Peter Simonsson.
Committed on 30/12/2020 at 05:43.
Pushed by psn into branch 'release/20.12'.

Don't allow spaces in ident and nick inputs

As the IRC protocol doesn't handle spaces in nicks or idents don't allow
the user add them to the input.

M  +32   -0    src/identitydialog.cpp

https://invent.kde.org/network/konversation/commit/47733e88b76822f61cd9fcc6ff0434ebf6223823