Bug 422105

Summary: When exiting full screen view by ESC, picture skips back to first viewed after a sequence
Product: [Applications] digikam Reporter: griffiths_andy
Component: Plugin-Generic-SlideShowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: griffiths_andy, metzpinguin
Priority: NOR    
Version First Reported In: 7.0.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/digikam/commit/186fe09a1f530c916a7bee00b2ebf4dd26db1c71 Version Fixed/Implemented In: 7.0.0
Sentry Crash Report:

Description griffiths_andy 2020-05-26 15:51:17 UTC 
SUMMARY

Build http://commits.kde.org/digikam/5c08af48ee59836d3bc89aa30197fe92d43f2caf

I selected a picture in thumb view and pressed full screen view icon. I moved along a few pictures using cursor keys and then pressed ESC. Instead of exiting full screen it skipped back to the first picture, sometimes even one before the first (if available). Then I had to press ESC a second time to exit full screen

STEPS TO REPRODUCE
1. Select a picture, press full screen, display picture
2. Use cursor keys to move along a few pictures
3. Press ESC. First selected picture is reshown
4. Press ESC again to exit full screen

OBSERVED RESULT
Full screen is not exiting cleanly. The exit appears to skip back either to the first, or some random number backwards, as sometimes it skipped back to the one just after the first. Regardless of how many it skips back, it always does it.

Note, Slideshow does not exhibit this behaviour.

EXPECTED RESULT
Full screen should exit at any point 

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2020-05-26 17:12:10 UTC 
I also noticed the problem at work today in the Windows version. Can't reproduce it here with my Linux version.

Maik
Comment 2 Maik Qualmann 2020-05-26 18:00:09 UTC 
Git commit 71bbb207a5c98f147c09daf02f02dd0afd2a280d by Maik Qualmann.
Committed on 26/05/2020 at 17:57.
Pushed by mqualmann into branch 'master'.

fix end of slideshow
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +2    -0    core/dplugins/generic/view/slideshow/common/slideshowloader.cpp

https://invent.kde.org/graphics/digikam/commit/71bbb207a5c98f147c09daf02f02dd0afd2a280d
Comment 3 Maik Qualmann 2020-05-26 18:44:09 UTC 
Only for left mouse click fixed...

Maik
Comment 4 Maik Qualmann 2020-05-26 19:47:03 UTC 
Git commit 186fe09a1f530c916a7bee00b2ebf4dd26db1c71 by Maik Qualmann.
Committed on 26/05/2020 at 19:44.
Pushed by mqualmann into branch 'master'.

remove primary action from slideshow button
FIXED-IN: 7.0.0

M  +0    -3    core/dplugins/generic/view/slideshow/slideshowplugin.cpp

https://invent.kde.org/graphics/digikam/commit/186fe09a1f530c916a7bee00b2ebf4dd26db1c71
Comment 5 griffiths_andy 2020-05-26 20:13:43 UTC 
I'll rebuild and try..
Comment 6 griffiths_andy 2020-05-26 20:38:10 UTC 
Fixed. Thanks.