Bug 422059

Summary:	4.3 Beta hard-depends on OpenEXR 2.4
Product:	[Applications] krita	Reporter:	Storm Engineer <storm.anthro>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	halla
Priority:	NOR
Version First Reported In:	4.3.0-beta1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Storm Engineer 2020-05-25 17:00:50 UTC

Building 4.3 Beta on Arch fils because the current version of OpenEXR on Arch is 2.5, and the build script specifically looks for 2.4. Downgrading to 2.4 for now solved it.

STEPS TO REPRODUCE
1. Try to build with OpenEXR 2.5

OBSERVED RESULT
make[2]: *** No rule to make target '/usr/lib/libHalf-2_4.so', needed by 'libs/pigment/libkritapigment.so.19.0.0'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:11076: libs/pigment/CMakeFiles/kritapigment.dir/all] Error 2

libHalf is part of OpenEXR.

EXPECTED RESULT
It should detect that the installed version is 2.5

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Archj Linux + Plasma 5

Comment 1 Halla Rempt 2020-05-26 10:07:16 UTC

Did you make a clean build? Our build system does not look explicitly for openexr 2.4:

find_package(OpenEXR)
set_package_properties(OpenEXR PROPERTIES
    DESCRIPTION "High dynamic-range (HDR) image file format"
    URL "https://www.openexr.com"
    TYPE OPTIONAL
    PURPOSE "Required by the Krita OpenEXR filter")
macro_bool_to_01(OPENEXR_FOUND HAVE_OPENEXR)
set(LINK_OPENEXR_LIB)
if(OPENEXR_FOUND)
    include_directories(SYSTEM ${OPENEXR_INCLUDE_DIRS})
    set(LINK_OPENEXR_LIB ${OPENEXR_LIBRARIES})
    add_definitions(${OPENEXR_DEFINITIONS})
endif()

Comment 2 Storm Engineer 2020-06-04 18:43:58 UTC

I did a full clean build (wiping directory) now and the issue didn't happen, so it seems this was my fault. Sorry.

Comment 3 Bug Janitor Service 2020-06-05 04:33:21 UTC

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.