| Summary: | "Get new <addon>" windows say "Loading more..." while an addon is updated if "Updateable only" filter is selected | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | admin, alexander.lohnau, kdelibs-bugs-null, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/knewstuff/commit/24d8b7c2fa5ea81d9b8322fa730de7f3b30a94f0 | Version Fixed/Implemented In: | 5.73 |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
This also appears when installing a new plugin. But in most cases the spinner is not shown, because the list of results is full. You can try this out by searching for "matrix kde" and install the one result. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/12 Git commit 24d8b7c2fa5ea81d9b8322fa730de7f3b30a94f0 by Alexander Lohnau. Committed on 11/08/2020 at 18:29. Pushed by alex into branch 'master'. Hide load more spinner while updating/installing FIXED-IN: 5.73 The isLoadingData state was always set to true when the busy signal gets emitted. But in the case of an installation there is no data in the sense of more entries loaded, consequently we don't need to show the spinner. Because of that this MR introduces a new API which tells exactly what operations are currently running. M +1 -1 src/core/CMakeLists.txt M +59 -11 src/core/engine.cpp M +74 -0 src/core/engine.h M +9 -3 src/qtquick/quickitemsmodel.cpp https://invent.kde.org/frameworks/knewstuff/commit/24d8b7c2fa5ea81d9b8322fa730de7f3b30a94f0 |
Created attachment 128764 [details] screenshot STEPS TO REPRODUCE 1. open a "Get new <addon>" window when an addon update is available 2. select "Updateable only" option in the second dropdown on bottom 3. hover over any updateable addon and click on its "Update" button OBSERVED RESULT "Get new <addon>" window says "Loading more..." on bottom while the addon is updated. See the attached screenshot please. EXPECTED RESULT "Loading more..." should not appear while the addon is updated. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.19.80 KDE Frameworks Version: 5.71.0 Qt Version: 5.14.2