| Summary: | KF5 5.70.0 regression: Dolphin shows same SMB share twice | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kio-extras | Reporter: | S <sb56637> |
| Component: | Samba | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | a.samirh78, kdelibs-bugs-null, sitter |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | 20.08 | |
| Sentry Crash Report: | |||
| Attachments: |
same device appears twice in Tumbleweed
same device appears twice in Tumbleweed Only 1 resource as expected in Leap 15.2 beta KIO logs libsmbclient logs KIO log from openSUSE Leap 15.2, which only shows the .local name libsmbclient log from openSUSE Leap 15.2, which only shows the .local name |
||
|
Description
S
2020-05-24 04:38:31 UTC
Created attachment 128736 [details]
same device appears twice in Tumbleweed
Created attachment 128737 [details]
same device appears twice in Tumbleweed
Created attachment 128738 [details]
Only 1 resource as expected in Leap 15.2 beta
one is discovered over netbios/smb1. the other is discovered over dnssd. server-side comments impact the entry name for netbios/smb1 and that's why there's two entries. the 'SMB/CIFS' comment makes the name different and because of that we simply don't know that they are the same remote. (that said, I'm not sure they would be the de-duplicated either way in 20.04 because of how NB and DNSSD interact with each other - bug #421624) Thanks for looking into this. It appears I was wrong about this being a problem limited to Dolphin / KIO. This is what I discovered: - Tumbleweed KDE, KF5 5.70.0 --> *duplicates* - openSUSE Leap 15.2 beta, KF5 5.69.0 --> no duplicates - Fedora 32 KDE, KF5 5.68.0 --> no duplicates - Fedora 32 Gnome 3.34 w/ Nautilus --> no duplicates - Ubuntu 20.04 Gnome 3.34 w/ Nautilus --> *duplicates* So I can't seem to find any rhyme or reason as to why some distros manifest this bug and others don't. Please provide a debug log https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves/Debugging_kio_smb#Reporting_Bugs @Harald Sitter Thanks for the link on how to log this stuff. I am attaching the requested information. To my untrained eye, it looks like maybe KIO is pulling the new style .local name from Avahi, whereas libsmbclient is finding the old NetBIOS name. libsmbclient0 version on Tumbleweed: 4.12.2+git.152.c5bf9f6da52 Created attachment 128766 [details]
KIO logs
Created attachment 128767 [details]
libsmbclient logs
"OpenMediaVault - SMB/CIFS" is discovered through DNSSD while "OPENMEDIAVAULT" is discovered through WS-Discovery. Which brings me back to my point that since they have different names we consider them different entities. Perhaps you should raise this with the openmediavault devs instead? This would be easily solved if the names on DNSSD and WSD were the same. Having divergent names for the same service entity is peculiar at the best of times. Created attachment 128768 [details]
KIO log from openSUSE Leap 15.2, which only shows the .local name
Created attachment 128769 [details]
libsmbclient log from openSUSE Leap 15.2, which only shows the .local name
(In reply to Harald Sitter from comment #10) > "OpenMediaVault - SMB/CIFS" is discovered through DNSSD while > "OPENMEDIAVAULT" is discovered through WS-Discovery. > Which brings me back to my point that since they have different names we > consider them different entities. > > Perhaps you should raise this with the openmediavault devs instead? This > would be easily solved if the names on DNSSD and WSD were the same. Having > divergent names for the same service entity is peculiar at the best of times. Yeah, I don't disagree. But then why doesn't this bug appear in Leap 15.2? There, libsmbclient also knows about "OPENMEDIAVAULT", but it doesn't appear in Dolphin. You'll have to ask opensuse. Presumably leap doesn't have a ws-discovery enabled kio-extras. What libsmbclient sees on a netbios boradcast doesn't matter for your specific case. It'd only apply to SMB1 discovery but in your case the discoveries come in through dnssd and wsd and both of those sit on top of libsmbclient/netbios. (In reply to Harald Sitter from comment #10) > Perhaps you should raise this with the openmediavault devs instead? This > would be easily solved if the names on DNSSD and WSD were the same. Having > divergent names for the same service entity is peculiar at the best of times. Here is the OpenMediaVault dev's take on that suggestion: https://github.com/openmediavault/openmediavault/issues/718#issuecomment-633617849 Git commit c29d0d12f6f3ce0f903b9858672c61ffe8f8c837 by Harald Sitter. Committed on 08/06/2020 at 09:04. Pushed by sitter into branch 'master'. smb: make duplicate detection case-insensitive this does cover more dupes and is more in line with how windows would behave (what with it being case insensitive in general) M +6 -1 smb/kio_smb_browse.cpp https://invent.kde.org/network/kio-extras/commit/c29d0d12f6f3ce0f903b9858672c61ffe8f8c837 I'm marking this fixed but it isn't exactly. The problem is that OMV sets this `- SMB/CIFS` suffix on avahi when wsdd doesn't have the suffix set and that simply renders the two services different for our purposes. |