| Summary: | Notification from Dolphin shows wrong amount of deleted files when I delete a folder located in a Samba share | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.samirh78, kde, kdelibs-bugs, nate, sitter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/b7a9b547662b2b00df2e5f7e0b36b23007a28010 | Version Fixed In: | 5.71 |
| Attachments: |
screenshot
debug log |
||
Can you reproduce this? How do you know there's 125 files? Are they actually all gone after deleting? Are there sub directories inside the directory you delete? also https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves/Debugging_kio_smb#Reporting_Bugs I for one cannot reproduce this. There is a bug with the notification that it doesn't actually update to N/N deleted (the deleted count is always off; I'm guessing because small files delete so fast that the deletion finishes and never bothers to "finalize" its notification to read 100/100 files and instead ends at 88/100). Thing is, for me the reference number is always the actual amount of files in the directory, the deleted count may be off, the reference count is never. Created attachment 128800 [details] debug log (In reply to Harald Sitter from comment #1) > Can you reproduce this? How do you know there's 125 files? Are they actually > all gone after deleting? Are there sub directories inside the directory you > delete? also > https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves/ > Debugging_kio_smb#Reporting_Bugs a. Yes, I can reproduce. b. Status bar of Dolphin shows the amount of files. c. Yes, all files are successfully deleted. d. I can reproduce this bug no matter if there is a sub directory inside the directory or not. Both client and server machines run Arch + samba 4.12.3. I'm attaching the debug log. Kai came up with https://invent.kde.org/frameworks/kio/-/merge_requests/13 Git commit b7a9b547662b2b00df2e5f7e0b36b23007a28010 by Kai Uwe Broulik. Committed on 26/05/2020 at 09:21. Pushed by dfaure into branch 'master'. [DeleteJob] Report final numbers after finishing We only report progress periodically, so we might finish the job without having reported the final numbers. M +5 -0 src/core/deletejob.cpp https://invent.kde.org/frameworks/kio/commit/b7a9b547662b2b00df2e5f7e0b36b23007a28010 |
Created attachment 128692 [details] screenshot STEPS TO REPRODUCE 1. open a Samba share with Dolphin 2. select a folder containing several files (I selected a folder containing 125 jpg files) 3. delete the selected folder by pressing shift+del OBSERVED RESULT Notification from Dolphin shows wrong amount of deleted files. See attached screenshot please. EXPECTED RESULT Notification from Dolphin should show the correct amount of deleted files. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.18.90 KDE Frameworks Version: 5.70.0 Qt Version: 5.15.0 rc2