| Summary: | [kcm/kwinrules X11] KWinRules KCM: Redesign Fallout: Position rule caps to 4098 | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Duncan <1i5t5.duncan> |
| Component: | rules | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | isma.af, nate |
| Priority: | NOR | ||
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/91eee99fca6979b598cbd9f52bec58a9e48fcf69 | Version Fixed/Implemented In: | 5.19 |
| Sentry Crash Report: | |||
| Attachments: | Patch maximum position to 65535 | ||
|
Description
Duncan
2020-05-22 02:04:39 UTC
Created attachment 128681 [details]
Patch maximum position to 65535
[Hmm... bugzi's a bit dated and still says phabricator for patches... Maybe I should file a bug on that too?]
Easy enough to grep 4098 and generate a patch even if I'm a gentooer not a dev...
65535 should be enough for awhile... not yet tested, tho.
(In reply to Duncan from comment #1) > Created attachment 128681 [details] > Patch maximum position to 65535 > 65535 should be enough for awhile... not yet tested, tho. Tested (to 6500 at least, I can still see that on-screen, and 65535 doesn't appear to break anything, tho the current kcmutils bug had me worried for a moment) now. Works. =:^) (I had rebuilt kcmutils in the same update and HEAD's buggy ATM. Couldn't find /any/ kcms and I thought my 65535 patch here broke it for a moment. HEAD-1 got it back tho so I could test this. Now to file the kcmutils bug if nobody's ahead of me...) Git commit 91eee99fca6979b598cbd9f52bec58a9e48fcf69 by Ismael Asensio. Committed on 22/05/2020 at 14:03. Pushed by iasensio into branch 'Plasma/5.19'. [kcm/kwinrules] Extend upper limit of position and size spinners Currently, the spinners used to edit position and size rules have an upper limit of 4098, which may be not enough for wide/hdpi/mutiple screens. The property itself has no such limit in the `.kcfg` schema This is just an issue with the editor. FIXED-IN: 5.19 M +2 -2 kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml https://invent.kde.org/plasma/kwin/commit/91eee99fca6979b598cbd9f52bec58a9e48fcf69 |