| Summary: | digiKam fails to compile with Qt 5.15 | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Christoph Feck <cfeck> |
| Component: | Portability-Compilation | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version First Reported In: | 7.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 7.0.0 | |
| Sentry Crash Report: | |||
|
Description
Christoph Feck
2020-05-20 10:53:34 UTC
Git commit 9ef1670e7ea0852cdfb694dd4d839977305bd4a2 by Gilles Caulier. Committed on 20/05/2020 at 11:05. Pushed by cgilles into branch 'master'. fix broken compilation with Qt 5.15 M +1 -0 core/libs/dimg/filters/levels/histogrampainter.cpp https://invent.kde.org/graphics/digikam/commit/9ef1670e7ea0852cdfb694dd4d839977305bd4a2 If there is more patch ti apply, let's me here. I don't have yet a Qt 5.15 installed on a computer to port the code... Gilles Thanks, there are indeed more occurrences. I will check if I can trick the openSUSE build service to compile with "make -k" to catch all errors. Next: core/libs/dimg/filters/curves/curveswidget.cpp:234:22: error: aggregate 'QPainterPath curvePath' has incomplete type and cannot be defined Since dimg couldn't be built, the build service wasn't able to continue building, so there might be more errors. Git commit f1c25adea778aca558eb38669249ab73d73c8798 by Gilles Caulier. Committed on 20/05/2020 at 18:56. Pushed by cgilles into branch 'master'. fix Qt 5.15 build M +1 -0 core/libs/dimg/filters/curves/curveswidget.cpp https://invent.kde.org/graphics/digikam/commit/f1c25adea778aca558eb38669249ab73d73c8798 Next: core/dplugins/generic/view/presentation/opengl/presentationgl.cpp needs <QPainterPath> and <QPainterPathStroker> We are getting closer :) Sorry for being too lazy to compile locally. Git commit f2bd9b4e7cfa57c3980ccc6d83c525cd0f6fad51 by Maik Qualmann. Committed on 20/05/2020 at 20:46. Pushed by mqualmann into branch 'master'. fix Qt 5.15 build #2 M +2 -0 core/dplugins/generic/view/presentation/opengl/presentationgl.cpp https://invent.kde.org/graphics/digikam/commit/f2bd9b4e7cfa57c3980ccc6d83c525cd0f6fad51 Thanks, it's green now in my OBS home repository, but it is build without many optional dependencies (e.g. marble, akonadi, etc.). I will check the log of the official builds (with more dependencies) tomorrow when the daily rebuild is triggered. I think they currently only include the first fix. https://build.opensuse.org/package/live_build_log/KDE:Unstable:Extra/digikam/KDE_Unstable_Frameworks_openSUSE_Factory/x86_64 Build succeeded (see link above). Perfect. Thanks Gilles Caulier Meanwhile, Qt 5.15.0 version was released, and I spotted one more include cleanup change compared to Qt 5.15.0-RC2: core/dplugins/generic/webservices/vkontakte/backend/vkontakte_authenticationdialog.cpp:105:84: error: invalid use of incomplete type 'class QNetworkCookieJar' (or that's new code in digikam?) Checking the source, I should clarify that I am building against QtWebKit instead of QtWebEngine. Yes, it's new code. Fixed : https://invent.kde.org/graphics/digikam/commit/cdff7d5a759399695fb024883d08758e98e90acf Gilles Merci, it's green again. |