Bug 421773

Summary: Create Blank frame using keyboard shortcut works, but on a wrong layer
Product: [Applications] krita Reporter: Vladimir Savic <vladimir.firefly.savic>
Component: AnimationAssignee: Eoin O'Neill <eoinoneill1991>
Status: RESOLVED NOT A BUG    
Severity: normal CC: ahab.greybeard, emmetoneill.pdx, eoinoneill1991, halla
Priority: NOR    
Version: 4.2.9   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Vladimir Savic 2020-05-19 11:58:13 UTC 
SUMMARY

By default there is no shortcut for this action, therefore, I've defined my own keyboard shortcut - "s".

Open a default document, with default layers: Background and Layer1. Show them in the timeline and unlock BG layer.


STEPS TO REPRODUCE
1. Move to some frame (let's say 10)
2. Hit key "s"
3. Observe that Blank frame is indeed created
4. Move to some other frame (let's go to 20)
4. Click at other layer in the Layers panel
5. Hit "s" again

OBSERVED RESULT

Even though one layer is selected, Blank frame is being created at previously selected layer.

Note: Hitting RMB at the correct time (frame) and layer box and choosing Create Blank frame from the context menu works as supposed.  

EXPECTED RESULT

A new blank frame is being created at the selected layer. 

SOFTWARE/OS VERSIONS
Manjaro Linux
Qt Version: 5.14.2

ADDITIONAL INFORMATION
Comment 1 Ahab Greybeard 2020-05-20 09:02:01 UTC 
Using a shorcut key for Create Blank Frame operates in the same way as the RMB method. The blank frame is created according to which layer/frame is selected in the Timeline docker.

When you do RMB on the Timeline, the Layers docker selected layer changes to the layer that was clicked in the Timeline docker.

When you do a keyboard shortcut on the Timeline, the Layers docker selected layer is not altered.

The Layers Docker selected layer determines where any drawing takes place.

The change of active layer in the Layers docker with the RMB method happens when you do the right-click and the context menu comes up. It seems that that this is bypassed when you use a keyboard shortcut.
Comment 2 Emmet O'Neill 2020-07-28 20:17:50 UTC 
As Ahab explained, the new keyframe is always created on the *selected* frame instead of the *active* one. So this isn't actually a bug, but part of the current design of the timeline docker.

That's not to say that we can't or won't improve the design in the future, of course, so we'll try to consider this as we rethink how things work within the timeline.

Thanks again for the feedback, Vladimir. I'm marking this a "not a bug" for now, but we'll keep it in mind.