| Summary: | [kcm/kwinrules X11] KWinRules KCM Redesign: Fallout: Placement | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Duncan <1i5t5.duncan> |
| Component: | rules | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | isma.af, kwin-bugs-null, nate, schwancarl |
| Priority: | NOR | ||
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/fdd9ed53d9a67089764d2879754c511f58da889e | Version Fixed/Implemented In: | 5.19.0 |
| Sentry Crash Report: | |||
|
Description
Duncan
2020-05-15 22:29:06 UTC
Git commit fdd9ed53d9a67089764d2879754c511f58da889e by Ismael Asensio. Committed on 18/05/2020 at 18:27. Pushed by iasensio into branch 'Plasma/5.19'. [kcm/kwinrules] Fix Placement setting Summary: Since the port to KConfigXT, the setting "placement" is stored using the enum value, instead of a string equivalent. This updates the kcm model to be able to communicate this property with the config schema. FIXED-IN: 5.19.0 Test Plan: - In a rule set the "Initial Placement" property - The value is stored in `~/.config/kwinrulesrc` - Close/reopen the kcm. The placement value is correctly loaded. Reviewers: #kwin, #plasma, zzag Reviewed By: #kwin, #plasma, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D29790 M +10 -11 kcmkwin/kwinrules/rulesmodel.cpp https://invent.kde.org/plasma/kwin/commit/fdd9ed53d9a67089764d2879754c511f58da889e (In reply to Ismael Asensio from comment #1) > Git commit fdd9ed53d9a67089764d2879754c511f58da889e by Ismael Asensio. Could you merge the 5.19 branch into Master? I'm on Master and am not seeing that commit here. The last two commits I'm seeing are current HEAD be245e2f8 (the no-phabricator patch that seems to be being applied pretty universally to kde products due to the gitlab migration), and 923340e6b from Friday, which merged the 5.19 branch (with db7fb26ee, your fix for bug #421055, the rules kcm size properties bug I reported). So I'm not seeing this one yet. But I've downloaded the patch and applied it manually (gentoo, so dropped it into /etc/portage/patches/kde-plasma/kwin and remerged the kwin-9999 live-git package from the gentoo/kde overlay), and yes, I can confirm that with it applied, changing a placement rule works as expected once again. Thanks. =:^) (In reply to Duncan from comment #2) > (In reply to Ismael Asensio from comment #1) > > Git commit fdd9ed53d9a67089764d2879754c511f58da889e by Ismael Asensio. > > Could you merge the 5.19 branch into Master? I'm on Master and am not > seeing that commit here. Branch w/ patch merged. Thanks. =:^) |