Bug 421542

Summary:	[kcm/kwinrules] Suggest Whole Window Class when detecting properties
Product:	[Plasma] kwin	Reporter:	Duncan <1i5t5.duncan>
Component:	rules	Assignee:	Ismael Asensio <isma.af>
Status:	RESOLVED FIXED
Severity:	normal	CC:	isma.af, kwin-bugs-null, nate
Priority:	NOR
Version:	git master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/d725fc59bf11663a8dc5df4b633c15f914b97f9b	Version Fixed In:	5.20
Sentry Crash Report:

Description Duncan 2020-05-15 02:02:40 UTC

+++ This bug was initially created as a clone of Bug #421540 +++
[Frameworks/plasma git-master, so this is the redesigned window rules kcm.  qt-5.15.0_rc ]

The rules kcm redesign seems to have no way to actually get the whole window class in ordered to match it.

The detection button will detect window class, but not whole window class (that I can figure out how, anyway, if it's there it's seriously unintuitive), and the match whole window class option doesn't appear to change that, so the only way to actually get the whole window class would be to use some third-party app (like xprop) to get it, and then fill it in manually.

And window role doesn't originally appear.  Not only is it not in the original matching list, but hitting add properties, it doesn't (originally) appear either -- tho the first slot under window matching is blank, and if you begin to type the first two letters of "role" (so "ro") in the search box, it does appear.  If you then close the add/select properties box and click add properties again (after searching for it the first time), it shows up in the position that was previously blank.

Comment 1 Ismael Asensio 2020-05-15 16:46:40 UTC

Hi Duncan,
This looks like two distinct bugs: detect whole window class, and window role being hidden.
Would you mind to create a new bug report for the second one, so it's easier for us to track them?
Thanks!

Comment 2 Duncan 2020-05-15 21:32:12 UTC

(In reply to Ismael Asensio from comment #1)
> This looks like two distinct bugs: detect whole window class, and window
> role being hidden.
> Would you mind to create a new bug report for the second one

Done.  Bug #421583.  Editing this one's title to reflect its now more limited scope.

(I had just created like four bugs on the redesign and didn't want to overdo it so grouped them slightly and both here were window match props, so... But happy to split it on the request. =:^)

Comment 3 Ismael Asensio 2020-05-31 10:51:48 UTC

Git commit d725fc59bf11663a8dc5df4b633c15f914b97f9b by Ismael Asensio.
Committed on 31/05/2020 at 10:51.
Pushed by iasensio into branch 'master'.

[kcm/kwinrules] Detect also window complete class

Summary:
When detecting the properties of a window, now it shows and lets the user select the window complete class.
If this property is selected in the overlay, `Window class` takes the whole class value, and the option `Match window whole class` is set.

This adds back a feature the old kcm was offering.
FIXED-IN: 5.20

Test Plan:
- `Detect window properties` and pick a firefox window
- The property selector shows: `Window class: navigator` and `Whole window class: navigator firefox`
- Selecting the latter set the properties as per summary

{F8334118}

Reviewers: ngraham, #kwin, #plasma, meven

Reviewed By: ngraham, #kwin, #plasma, meven

Subscribers: broulik, davidedmundson, meven, anthonyfieroni, zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D29791

M  +1    -1    kcmkwin/kwinrules/ruleitem.cpp
M  +2    -1    kcmkwin/kwinrules/ruleitem.h
M  +38   -8    kcmkwin/kwinrules/rulesmodel.cpp
M  +2    -0    kcmkwin/kwinrules/rulesmodel.h

https://invent.kde.org/plasma/kwin/commit/d725fc59bf11663a8dc5df4b633c15f914b97f9b