Bug 421513

Summary: Configuration of the disk usage applet does not make clear which sensor relates to which partition / disk
Product: [Plasma] plasmashell Reporter: Luca Beltrame <lbeltrame>
Component: System Monitor widgetsAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Configuration screen detail

Description Luca Beltrame 2020-05-14 13:49:34 UTC
Created attachment 128454 [details]
Configuration screen detail

SUMMARY

When configuring sensors in the disk usage applet, the list is full of "percentage used" but it is absolutely not clear which sensors refer to which disk.

Screenshot attached.

STEPS TO REPRODUCE
1. Add a Disk Usage applet do the desktop
2. Open applet configuration
3. Move to "Sensors Details"

OBSERVED RESULT

No relationship between the sensor color and the disk (neither on clicking, nor on hovering).

EXPECTED RESULT

Each sensor should tell which partition / disk / path it refers to.

SOFTWARE/OS VERSIONS

Plasma from git master (as of 2020-05-14), KF5 from git master (same as Plasma), Qt 5.15 RC.
Comment 1 Nate Graham 2020-05-14 14:16:07 UTC
https://phabricator.kde.org/D29752
Comment 2 David Edmundson 2020-05-14 14:35:05 UTC
Git commit ae6c4ac8e39d9a2219ada24c4dae02d8e61ab5b0 by David Edmundson.
Committed on 14/05/2020 at 14:34.
Pushed by davidedmundson into branch 'Plasma/5.19'.

Prefix disk name on size labels

Summary:
labels for CPU frequency are "CPU 1 Clock Frequency". Network speeds
have the interface name at front.  Partitions didn't match, leaving the
key in the graph to be just "Available" several times if you plotted
multiple disks.

This adds a prefix so it's consistent.

Reviewers: lbeltrame, #plasma, ahiemstra

Reviewed By: ahiemstra

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29752

M  +7    -8    ksysguardd/Linux/diskstat.c

https://commits.kde.org/ksysguard/ae6c4ac8e39d9a2219ada24c4dae02d8e61ab5b0