| Summary: | Visual regression in disk usage applet | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Luca Beltrame <lbeltrame> |
| Component: | System Monitor | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, plasma-bugs |
| Priority: | VHI | Keywords: | regression |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libksysguard/commit/a94e688889842f348211883e2396513372d48c90 | Version Fixed In: | 5.20 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of default applet | ||
In fact I notice that all of them seem to come with no legend by default now :/ did the situation improve on current master/latest backports to 5.19? A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/43 Git commit a94e688889842f348211883e2396513372d48c90 by Marco Martin. Committed on 10/07/2020 at 15:22. Pushed by mart into branch 'master'. new face: Horizontal bars this new face draws horizontal bars with rounded edges (to look kinda breeze-y) though they are just rounded Rectangles in order to alwys support correct custom coloring for bars. Legends are immediately below the bar instead of grouped, which makes it much more readable in this case. It looks also pretty similar to the old partitions monitor, effectively fixing M +0 -1 faces/SensorFaceController.cpp M +1 -0 faces/facepackages/CMakeLists.txt A +2 -0 faces/facepackages/horizontalbars/Messages.sh A +5 -0 faces/facepackages/horizontalbars/contents/faceproperties A +52 -0 faces/facepackages/horizontalbars/contents/ui/Bar.qml [License: LGPL (v2+)] A +57 -0 faces/facepackages/horizontalbars/contents/ui/CompactRepresentation.qml [License: LGPL (v2+)] A +118 -0 faces/facepackages/horizontalbars/contents/ui/FullRepresentation.qml [License: LGPL (v2+)] A +13 -0 faces/facepackages/horizontalbars/metadata.desktop https://invent.kde.org/plasma/libksysguard/commit/a94e688889842f348211883e2396513372d48c90 |
Created attachment 128453 [details] Screenshot of default applet SUMMARY The new system monitor applet with regards to disk usage generates, by default, an applet that is totally unreadable, with many bars and with no clear indication to which bar corresponds to which partition / mountpoint. Screenshot attached. STEPS TO REPRODUCE 1. Add "Disk Usage" to desktop OBSERVED RESULT Applet with unreadable and thin colored bars EXPECTED RESULT An applet similar to the one existing before the rewrite. SOFTWARE/OS VERSIONS Plasma from git master (as of 2020-05-14), KF5 from git master (same date) and Qt 5.15 RC.