Bug 421372

Summary:	Move search field close button to right
Product:	[Applications] dolphin	Reporter:	Andres Betts <anditosan1000>
Component:	search	Assignee:	Nate Graham <nate>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dolphin-bugs-null, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/system/dolphin/commit/1ee665bac8bd7f79d242213ebfd7d2095d392523	Version Fixed/Implemented In:	20.08.0
Sentry Crash Report:

Description Andres Betts 2020-05-11 20:57:50 UTC

SUMMARY
In the search for dolphin files, the close tab button appears on the left instead of the predictable right.

I would like to request visual consistency in the ui by moving the close button to the right on the search tabs, like the rest of the ui.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Nate Graham 2020-05-12 20:19:50 UTC

Will be fixed by https://phabricator.kde.org/D29693

Comment 2 Nate Graham 2020-05-18 13:30:17 UTC

Git commit 1ee665bac8bd7f79d242213ebfd7d2095d392523 by Nate Graham.
Committed on 18/05/2020 at 13:30.
Pushed by ngraham into branch 'master'.

Move search and filter bar close buttons to the right

Summary:
Close buttons for windows, tabs, and pretty much everything else in KDE are on the right,
not the left. This patch makes Dolphin's search and filter bars follow that.
FIXED-IN: 20.08.0

Test Plan: {F8314176}

Reviewers: abetts, #dolphin, #vdg, elvisangelaccio, GB_2

Reviewed By: #dolphin, #vdg, elvisangelaccio, GB_2

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D29693

M  +8    -8    src/filterbar/filterbar.cpp
M  +8    -8    src/search/dolphinsearchbox.cpp

https://invent.kde.org/system/dolphin/commit/1ee665bac8bd7f79d242213ebfd7d2095d392523