Bug 421290

Summary:	Filename: double quote sign (") used in filename is not kept as-is in resulting filename on disk
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Valdo <gnu4ever>
Component:	Open/save dialogs	Assignee:	KIO Bugs <kio-bugs-null>
Status:	REPORTED ---
Severity:	normal	CC:	bugseforuns, christoph, justin.zobel, kdelibs-bugs-null
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	File saved as « my "blah" file.txt » is actually saved as just « blah » on disk.

Description Valdo 2020-05-10 15:55:30 UTC

SUMMARY

Handling of double quote signs in filenames has never been satisfying with Kate, but version 19.x might even be worst than before.

* CASE 1:

STEPS TO REPRODUCE
1. Create a new file with Kate.
2. Save it under name:
my "blah" file.txt

OBSERVED RESULT
Saved file is named:
blah

EXPECTED RESULT
Saved file should be named on disk:
my "blah" file.txt

* CASE 2:

STEPS TO REPRODUCE
1. Create a new file with Kate.
2. Click on Save button
3. Name file (but don't save yet!):
my "blah" file.txt
4. Enter some subdirectory from current location -> filename is automatically renamed as:
my %22blah%22 file.txt
(doesn't sound bad... but wait ^^)
5. Go up one level (to the initial location) -> filename is automatically renamed as:
my %2522blah%2522 file.txt
6. Enter some subdirectory again -> filename is automatically renamed as:
my %252522blah%252522 file.txt
7. Etc.?

OBSERVED RESULT
1. Filename changes each time a directory is entered or exited.
2. If you finally click "Save", the resulting filename is actually what it reads, for e.g.:
my %252522blah%252522 file.txt

EXPECTED RESULT
1. Filename should not change each time a directory is entered or exited.
2. Saved file should be named on disk:
my "bla" file.txt

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8

ADDITIONAL INFORMATION
My Kate encoding: Unicode (UTF-8)
My Plasma regional setting: French

Comment 1 Justin Zobel 2020-11-13 05:25:30 UTC

Case 1 for me results in an error and I'm not sure double quotes should ever be in filenames.

Case 2 I can't reproduce.

Can you please test and confirm if the case 2 issue is still occurring or if this bug report can be marked as resolved. I'm setting status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thanks.

Comment 2 Valdo 2020-11-14 01:02:37 UTC

(In reply to Justin Zobel from comment #1)
> Case 1 for me results in an error and I'm not sure double quotes should ever
> be in filenames.
> 
> Case 2 I can't reproduce.
> 
> Can you please test and confirm if the case 2 issue is still occurring or if
> this bug report can be marked as resolved. I'm setting status to "needsinfo"
> pending your response, please change back to "reported" or "resolved" when
> you respond, thanks.
Thanks for you reply. What are your locale and regional language please? They may play a role, considering your Kate behaviour is totally different from mine's.

* CASE 1: what kind of error message do you get?
(the fact that one should or should not include double quotes in filenames is out of scope IMO)

* CASE 2: meaning your filename preserves double quotes and doesn't turn them into %22, then into %2522, %252522, etc.?
On my end, it still behaves as it did when I raised these bugs.

Comment 3 Christoph Cullmann 2021-06-03 18:10:41 UTC

Hmm, I think the file dialog has there some issues.

e.g. entering

my "blah" file.txt

as file name leads to the error message: "You can only select one file" in the save file dialog.

That is a standard kio file dialog via the platform integration.

Comment 4 Patrick Silva 2021-06-12 14:44:07 UTC

(In reply to Christoph Cullmann from comment #3)
> Hmm, I think the file dialog has there some issues.
> 
> e.g. entering
> 
> my "blah" file.txt
> 
> as file name leads to the error message: "You can only select one file" in
> the save file dialog.


reported as bug 426728

Comment 5 Valdo 2021-08-01 08:22:44 UTC

Created attachment 140436 [details]
File saved as « my "blah" file.txt » is actually saved as just « blah » on disk.

In reply to comment #3: that's really strange... I don't face any error message (Kate 19.12.3 - KDE Frameworks 5.68.0). Instead, the file keeps being saved as « blah » (without quotation marks).