Bug 421280

Summary:	Answers marked as correct are not correct answers
Product:	[Applications] kwordquiz	Reporter:	promike1987
Component:	general	Assignee:	Peter Hedlund <peter>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aacid
Priority:	NOR
Version First Reported In:	20.04
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/kwordquiz/acc0d0ad5315b9c57a4f03c547903aa160926fde	Version Fixed/Implemented In:
Sentry Crash Report:

Description promike1987 2020-05-10 14:19:11 UTC

SUMMARY
Hello,
Even though I mark certain answers as correct ones, 'Repeat Errors' puts them in the list again.

STEPS TO REPRODUCE
1. Open a file e.g. $ kwordquiz -g qa listofwords.csv
2. Make a few mistakes and mark some of them as correct
3. Repeat Errors

OBSERVED RESULT
You will have more questions than the number of errors you'd made in the previous round (since those are also included that were marked as correct answers)

EXPECTED RESULT
Answers that has been marked as correct, wouldn't be in the list again.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.69.0
Qt Version: 5.14.2
OS Type 64-bit
KWordQuiz: 20.04.0

Comment 1 Albert Astals Cid 2020-05-10 21:18:52 UTC

Git commit acc0d0ad5315b9c57a4f03c547903aa160926fde by Albert Astals Cid.
Committed on 10/05/2020 at 21:15.
Pushed by aacid into branch 'release/20.04'.

Fix answers marked as correct showing up when "Repeating Errors"

The old code was removingLast from a temporary ^_^

M  +6    -0    src/kwqquizmodel.cpp
M  +1    -0    src/kwqquizmodel.h
M  +1    -1    src/qaview.cpp

https://commits.kde.org/kwordquiz/acc0d0ad5315b9c57a4f03c547903aa160926fde