Bug 421245

Still an issue. I recently created a script to save current session each time there is a change but having this internally in konqueror as it is in dolphin would be much better

A possibly relevant merge request was started @ https://invent.kde.org/network/konqueror/-/merge_requests/188

Git commit 6393fafc2633ef2a4112b10abcd84102529bd587 by Stefano Crocco.
Committed on 07/05/2023 at 09:49.
Pushed by stefanocrocco into branch 'master'.

Add option to restore last window when starting Konqueror again

M  +10   -1    settings/konqhtml/generalopts.cpp
M  +2    -0    settings/konqhtml/generalopts.h
M  +10   -3    src/konqapplication.cpp
M  +13   -0    src/konqmainwindow.h
M  +34   -0    src/konqsessionmanager.cpp
M  +17   -0    src/konqsessionmanager.h

https://invent.kde.org/network/konqueror/commit/6393fafc2633ef2a4112b10abcd84102529bd587

Note that the option is disabled by default. You must enable it in the "General" page of the settings dialog.

Awesome!

Hi Stefano, there is one issue with this new feature (that otherwise is working great!), which is when opening a link while Konqueror is closed.

The expected behavior would be to load all previous tabs and the new link in an additional tab.

The observed behavior is that only the previous tabs are opened, so I need to open the link again to load the new tab.

(In reply to avlas from comment #6)
> Hi Stefano, there is one issue with this new feature (that otherwise is
> working great!), which is when opening a link while Konqueror is closed.
> 
> The expected behavior would be to load all previous tabs and the new link in
> an additional tab.
> 
> The observed behavior is that only the previous tabs are opened, so I need
> to open the link again to load the new tab.

I can't reproduce this behavior. If I click on a link, for example in an e-mail, Konqueror opens with a single tab displaying that link, which is the opposite of what you are experiencing. Are you doing something specific to open the link? I tried by clicking a link in an e-mail.

(In reply to Stefano Crocco from comment #7)
> (In reply to avlas from comment #6)
> > Hi Stefano, there is one issue with this new feature (that otherwise is
> > working great!), which is when opening a link while Konqueror is closed.
> > 
> > The expected behavior would be to load all previous tabs and the new link in
> > an additional tab.
> > 
> > The observed behavior is that only the previous tabs are opened, so I need
> > to open the link again to load the new tab.
> 
> I can't reproduce this behavior. If I click on a link, for example in an
> e-mail, Konqueror opens with a single tab displaying that link, which is the
> opposite of what you are experiencing. Are you doing something specific to
> open the link? I tried by clicking a link in an e-mail.

I guess that to reproduce the issue you probably need to:

1. check the option to restore tabs in settings
2. open some tabs
3. close konqueror
4. click on the email link

Could you please try to reproduce following these steps?

(In reply to avlas from comment #8)
> (In reply to Stefano Crocco from comment #7)
> I guess that to reproduce the issue you probably need to:
> 
> 1. check the option to restore tabs in settings
> 2. open some tabs
> 3. close konqueror
> 4. click on the email link
> 
> Could you please try to reproduce following these steps?

That's what I already tried. I checked again, with both my current user and a new user and the results are the same I already described: a new window with only the page corresponding to the link. I'll look again into this issue during the weekend, but I really can't think of something leading to the behavior you're describing.

(In reply to Stefano Crocco from comment #9)
> (In reply to avlas from comment #8)
> > (In reply to Stefano Crocco from comment #7)
> > I guess that to reproduce the issue you probably need to:
> > 
> > 1. check the option to restore tabs in settings
> > 2. open some tabs
> > 3. close konqueror
> > 4. click on the email link
> > 
> > Could you please try to reproduce following these steps?
> 
> That's what I already tried. I checked again, with both my current user and
> a new user and the results are the same I already described: a new window
> with only the page corresponding to the link. I'll look again into this
> issue during the weekend, but I really can't think of something leading to
> the behavior you're describing.

I see. I think you may also need to check the setting to open links in new tabs instead of in new windows. Can you try?

(In reply to avlas from comment #10)
> (In reply to Stefano Crocco from comment #9)
> > (In reply to avlas from comment #8)
> > > (In reply to Stefano Crocco from comment #7)
> > > I guess that to reproduce the issue you probably need to:
> > > 
> > > 1. check the option to restore tabs in settings
> > > 2. open some tabs
> > > 3. close konqueror
> > > 4. click on the email link
> > > 
> > > Could you please try to reproduce following these steps?
> > 
> > That's what I already tried. I checked again, with both my current user and
> > a new user and the results are the same I already described: a new window
> > with only the page corresponding to the link. I'll look again into this
> > issue during the weekend, but I really can't think of something leading to
> > the behavior you're describing.
> 
> I see. I think you may also need to check the setting to open links in new
> tabs instead of in new windows. Can you try?

I always have it enabled, so that's not the problem.

Could you please try with a new user?

(In reply to Stefano Crocco from comment #11)
> (In reply to avlas from comment #10)
> > (In reply to Stefano Crocco from comment #9)
> > > (In reply to avlas from comment #8)
> > > > (In reply to Stefano Crocco from comment #7)
> > > > I guess that to reproduce the issue you probably need to:
> > > > 
> > > > 1. check the option to restore tabs in settings
> > > > 2. open some tabs
> > > > 3. close konqueror
> > > > 4. click on the email link
> > > > 
> > > > Could you please try to reproduce following these steps?
> > > 
> > > That's what I already tried. I checked again, with both my current user and
> > > a new user and the results are the same I already described: a new window
> > > with only the page corresponding to the link. I'll look again into this
> > > issue during the weekend, but I really can't think of something leading to
> > > the behavior you're describing.
> > 
> > I see. I think you may also need to check the setting to open links in new
> > tabs instead of in new windows. Can you try?
> 
> I always have it enabled, so that's not the problem.
> 
> Could you please try with a new user?

Mmm, but that's also unexpected, isn't it? shouldn't the link then open in a new tab instead of a new window?

I will try to test from scratch and let you know about the result

I removed konquerorrc from .config (actually just moved it out), which is the most similar thing to start from scratch I could imagine. All my settings were gone with this. I realized of two things:

1. Restore tabs setting does not initialize unless you have had at least 2 tabs open since you first activated the setting. once you have had 2 tabs open, then restore tabs works for any number of tabs, including just 1.

2. I always reproduce the issue I mentioned, I can never get external links to open neither as tabs (as expected if you have enabled that in settings) nor in a second window (as it happens to you). I wonder if this is related to the setting: keeping a preloaded instance, which I disabled.

I will try next with that setting active

(In reply to avlas from comment #13)
> I removed konquerorrc from .config (actually just moved it out), which is
> the most similar thing to start from scratch I could imagine. All my
> settings were gone with this. I realized of two things:
> 
> 1. Restore tabs setting does not initialize unless you have had at least 2
> tabs open since you first activated the setting. once you have had 2 tabs
> open, then restore tabs works for any number of tabs, including just 1.
> 
> 2. I always reproduce the issue I mentioned, I can never get external links
> to open neither as tabs (as expected if you have enabled that in settings)
> nor in a second window (as it happens to you). I wonder if this is related
> to the setting: keeping a preloaded instance, which I disabled.
> 
> I will try next with that setting active

Well, actually restore tabs functionality does not work at all if keeping a preloaded instance is active, meaning that the link is opened but previous tabs are not

> Well, actually restore tabs functionality does not work at all if keeping a
> preloaded instance is active, meaning that the link is opened but previous
> tabs are not

I'll look into this

I fixed the issue with session restoring not working when preloading is enabled. I also made a change which makes Konqueror work more like Dolphin in this regard: now, when launching Konqueror with one or more URLs, it will both restore the previous state and open the given URLs. Previously, in this situation, the saved state was ignored (my reasoning was that if the user asked for a specific URL, he didn't want others).

(In reply to Stefano Crocco from comment #16)
> I fixed the issue with session restoring not working when preloading is
> enabled. I also made a change which makes Konqueror work more like Dolphin
> in this regard: now, when launching Konqueror with one or more URLs, it will
> both restore the previous state and open the given URLs. Previously, in this
> situation, the saved state was ignored (my reasoning was that if the user
> asked for a specific URL, he didn't want others).

Excellent, it works great! And the new implementation fits with that of other browsers :)