| Summary: | Focus tracking not working with full desktop zoom. | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Jos Wijdeven <josser900ca> |
| Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gladhorn |
| Priority: | NOR | ||
| Version First Reported In: | 5.18.4 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/c1ea0412a45a64d99c120eedfa80ef376c7e6610 | Version Fixed In: | 5.20.0 |
| Sentry Crash Report: | |||
|
Description
Jos Wijdeven
2020-05-09 17:46:13 UTC
(In reply to Jos Wijdeven from comment #0) > ADDITIONAL INFORMATION > Looking at the source code on github > (https://github.com/KDE/kwin/tree/master/effects/zoom) it seems that > kaccessible (org.kde.kaccessibleapp) is used for focus tracking. But that > package is not installed and not available (any more) in the repository. > If this is the cause and if kaccessible is deprecated can the zoom component > be updated to use another way to follow the focus? Yes, kaccessible is dead. We should use libqaccessibilityclient. The focus tracking had been brought up to the discussion quite a while ago (see bug 362189) and I even wrote a patch to port the zoom effect to libqaccessibilityclient. However, someone had started reasoning whether focus tracking is actually needed in the zoom effect and the discussion kind of died out after that. *** This bug has been marked as a duplicate of bug 362189 *** Thank you. Yes, I had seen the other bug but that was about the caret (text cursor) tracking? (which is high on my wish list too) Or is what I described/expected not what "Enable focus tracking" and "Follow focus" are supposed to do? (In reply to Jos Wijdeven from comment #2) > Thank you. Yes, I had seen the other bug but that was about the caret (text > cursor) tracking? (which is high on my wish list too) > Or is what I described/expected not what "Enable focus tracking" and "Follow > focus" are supposed to do? So, iirc with the focus tracking, the zoom effect ensures that the focused region (e.g. a ui control) is in the zoom area. It's not about focused or newly opened windows. In general, we should answer first whether the zoom effect needs to have accessibility features such as focus tracking or caret tracking. If indeed it needs to have those features, then I would be glad to accept/approve a patch that ports the zoom effect to libqaccessibilityclient. Yeah, I probably marked this bug report as a duplicate of 362189 too quickly. @Frederik Does libqaccessibilityclient allow to track the focused region? The zoom effect itself is already an accessibility feature. I (and a lot of visually impaired users) can't use a computer without it. Adding/fixing the focus tracking will be greatly appreciated. Git commit c1ea0412a45a64d99c120eedfa80ef376c7e6610 by Vlad Zahorodnii. Committed on 01/06/2020 at 07:43. Pushed by vladz into branch 'master'. [effects/zoom] Implement focus tracking with QAccessibilityClient Currently, the focus tracking functionality in the zoom effect does not work because it relies on kaccessibleapp, which is dead. Luckily for us, there is a library called libqaccessibilityclient that provides a way to monitor focus changes. M +9 -0 CMakeLists.txt M +1 -0 config-kwin.h.cmake M +15 -0 effects/CMakeLists.txt A +91 -0 effects/zoom/accessibilityintegration.cpp [License: GPL (v2)] A +53 -0 effects/zoom/accessibilityintegration.h [License: GPL (v2)] M +26 -31 effects/zoom/zoom.cpp M +12 -11 effects/zoom/zoom.h M +0 -2 effects/zoom/zoom.kcfg M +4 -0 effects/zoom/zoom_config.cpp M +5 -39 effects/zoom/zoom_config.ui https://invent.kde.org/plasma/kwin/commit/c1ea0412a45a64d99c120eedfa80ef376c7e6610 |