Bug 421223

Summary: Issues with adding guides and rendering to the end
Product: [Applications] kdenlive Reporter: martian <gangulyabir777>
Component: Rendering & ExportAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal CC: fritzibaby, julius.kuenzel, snd.noise
Priority: NOR Flags: fritzibaby: Brainstorm+
Version First Reported In: 20.08.0   
Target Milestone: ---   
Platform: unspecified   
OS: Unspecified   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description martian 2020-05-09 13:23:42 UTC 
SUMMARY
If you try to render a video, using guide zone, setting "to" as "End", kdenlive will render to the end of the timeline, not the end of the clip.

STEPS TO REPRODUCE
1. Add a clip to the timeline.
2. Add a guide anywhere in between the clip(let's name this guide "cat").
3. Now, open the Render window chosse "Guide zone", then choose "from" as "cat" and "to" as "End"
4. "Press render to file"

OBSERVED RESULT
Notice the rendered file contains the video clip from guide "cat" to the "end of the timeline", i.e., you will see "dark", after the video ends.

EXPECTED RESULT
The video clip from the guide "cat" to the end of the video. There will be no black/dark after the video ends.

SOFTWARE/OS VERSIONS
Unspecified

ADDITIONAL INFORMATION
This happens because "End" literally means the "End of the timeline", not "the end of the video"(though I am not quite sure...)

If you do "render whole project", it will smartly trim the video. Why not the same in case of guides?

Right now, I have to find the exact point at which the video ends, add a guide there then render accordingly.
Comment 1 emohr 2020-09-12 12:02:06 UTC 
Confirmed. "End" seems to be set 10 minutes after the last clip.
Comment 2 martian 2020-09-18 15:00:04 UTC 
I just tried to solve this bug by myself.

changing line 481(near about) of src/dialogs/renderwidget.cpp to:
double projectDuration = GenTime(pCore->projectDuration() - 2, pCore->getCurrentFps()).ms() / 1000;

seems to solve the issue...

I am still in doubt that how it solves the issue(and what caused the issue), I would highly appreciate someone who can help me understand how this fix works.
Comment 3 farid 2021-03-22 21:12:39 UTC 
Still happening in master
Comment 4 Julius Künzel 2021-03-25 21:30:47 UTC 
(In reply to martian from comment #2)
> I just tried to solve this bug by myself.
> 
> changing line 481(near about) of src/dialogs/renderwidget.cpp to:
> double projectDuration = GenTime(pCore->projectDuration() - 2,
> pCore->getCurrentFps()).ms() / 1000;
> 
> seems to solve the issue...
> 
> I am still in doubt that how it solves the issue(and what caused the issue),
> I would highly appreciate someone who can help me understand how this fix
> works.

Thanks for the report and your attempt to fix! It would be nice if you can open a merge request on  https://invent.kde.org/multimedia/kdenlive. On GitLab we can review coding contributions better…