Bug 420865

Summary: "Labels" tab in left menu shows unexpected behavior
Product: [Applications] digikam Reporter: harald.aust
Component: Searches-LabelsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.0.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In: 7.0.0
Sentry Crash Report:
Attachments: No AND connection on Labels tab
Correct screenshot

Description harald.aust 2020-05-01 17:09:55 UTC
Created attachment 128064 [details]
No AND connection on Labels tab

Two observations on the "Labels" tab in the left panel of which I don't know whether they are bugs or intended behavior.

1. The digKam handbook says "You may select more than one label by Ctrl+left click. The selected labels are connected by boolean AND". If that were true, one should not be able to view something like the screenshot attached. My impression is that the logic is "Rating AND (Pick OR Color)". Is that intended? If so, the description in the handbook is wrong.

2. For Pick and Color, when choosing "No Pick" or "No Color", respectively, only pictures are shown that once were labelled with a Pick or a Color in digiKam, that later was deleted. Pictures that never had a Pick or a Color are not selected.


SOFTWARE/OS VERSIONS
Windows: Win 10 1809 64bit
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 harald.aust 2020-05-01 17:13:41 UTC
Created attachment 128065 [details]
Correct screenshot

Please ignore the screenshot above and use this one. I have no idea why, in the first screenshot, the second picture is shown without Rating. It's in the screenshot only, not in digiKam.

Best regards,
Harald
Comment 2 Maik Qualmann 2020-05-02 06:52:15 UTC
I am actually aware of the problem. For no color label and flag, a database operation is whether entries are present. This function does not work safely. Deleting a color label / flag / rating leaves an entry in the DB. So we have to check the value.

Maik
Comment 3 Maik Qualmann 2020-05-03 06:39:25 UTC
Git commit 0fdb12f3977732fa7fd4d2314a457affe65e3f30 by Maik Qualmann.
Committed on 03/05/2020 at 06:37.
Pushed by mqualmann into branch 'master'.

fix the XML query for no color or pick labels
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +27   -18   core/libs/album/treeview/albumlabelssearchhandler.cpp

https://invent.kde.org/kde/digikam/commit/0fdb12f3977732fa7fd4d2314a457affe65e3f30