Bug 420863

Summary:	Broken rectangular region selection on Wayland
Product:	[Applications] Spectacle	Reporter:	Matej Mrenica <matejm98mthw>
Component:	General	Assignee:	Boudhayan Gupta <me>
Status:	VERIFIED FIXED
Severity:	normal	CC:	kde, matejm98mthw, meven.car, nate, rainer, torotil
Priority:	NOR	Keywords:	wayland
Version:	20.08.1
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/spectacle/commit/4a3cb5140cc58d73b1f0f0083d7f24f9f3a40b2a	Version Fixed In:	20.12
Sentry Crash Report:

Description Matej Mrenica 2020-05-01 16:02:53 UTC

SUMMARY
If you try to take a screenshot with rectangular selection on Wayland this is how it looks like:
1. Your screen contents will be rendered in the top left corner taking exactly 1/4th of the screen.
2. This area will act as a window so it will move all your other windows out of there
3. You will be able to create a rectangular region inside this area that reports size values as if it covered the entire screen.
Although these sizes are still affected by the bug that takes screenshots in the scaled down resolution, not the original.
4. The final screenshot taken looks correctly / as if it is cut out of a screenshot of the entire screen, not 1/4 resolution.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.69
Qt Version: 5.15 Beta

ADDITIONAL INFORMATION
I also use fractional scaling at 125%.

Comment 1 Méven Car 2020-05-06 14:39:27 UTC

Will be addressed by https://phabricator.kde.org/D29282

Comment 2 Rainer Finke 2020-09-20 09:28:58 UTC

I've noticed the same issue now on Plasma 5.19.90 on Wayland and thought it was related to a change in Plasma. Seems like we have to wait then for KDE Applications 20.12 to get this bug fixed...

Operating System: Arch Linux
KDE Plasma Version: 5.19.90
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1
Kernel Version: 5.8.10-arch1-1
OS Type: 64-bit
Processors: 4 × Intel® Core™ i7-5600U CPU @ 2.60GHz
Memory: 7.7 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 5500

Comment 3 Nate Graham 2020-11-20 14:21:22 UTC

Git commit 4a3cb5140cc58d73b1f0f0083d7f24f9f3a40b2a by Nate Graham, on behalf of Méven Car.
Committed on 20/11/2020 at 14:21.
Pushed by ngraham into branch 'release/20.12'.

Support Wayland rectangular selection HiDpi

When the drawn rectangle is on a single screen, the output image uses the screen native resolution.
When the drawn rectangle is on screens with multiple scale factor, the output image is upscaled to correspond to the screen with the hightest scale factor to keep the image undistorted.

Adds also a "scaled" full screen mode, to capture screens content downscaled to screens virtualsize allowing for undistorted content albeit loosing details.

Requires Plasma 5.19.80+
Related: bug 409762
FIXED-IN: 20.12

M  +17   -9    src/Gui/KSWidget.cpp
M  +7    -1    src/Platforms/Platform.h
M  +133  -21   src/Platforms/PlatformKWinWayland.cpp
M  +11   -2    src/Platforms/PlatformKWinWayland.h
M  +1    -1    src/Platforms/PlatformNull.cpp
M  +15   -1    src/Platforms/PlatformXcb.cpp
A  +41   -0    src/QuickEditor/ComparableQPoint.h     [License: LGPL (v2+)]
M  +274  -91   src/QuickEditor/QuickEditor.cpp
M  +15   -3    src/QuickEditor/QuickEditor.h
M  +2    -1    src/SpectacleCommon.h
M  +35   -11   src/SpectacleCore.cpp
M  +1    -0    src/SpectacleCore.h

https://invent.kde.org/graphics/spectacle/commit/4a3cb5140cc58d73b1f0f0083d7f24f9f3a40b2a

Comment 4 Nate Graham 2020-11-20 17:57:32 UTC

Verified. Woohoooooooooo!