Summary: | "%"-symbol in bookmark address appears like "%25" | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | SimPS <tahir.jalilov> |
Component: | bookmark | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate, zawertun |
Priority: | NOR | ||
Version: | 20.04.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/konsole/commit/35ff3a72cefea944000d166a7919291e74e03d9e | Version Fixed In: | 20.08.0 |
Attachments: |
Visual representation of the bug
konsole_fix_bookmark_command_being_percent_encoded.patch konsole_fix_bookmark_command_being_percent_encoded.patch |
Description
SimPS
2020-04-30 09:31:50 UTC
How to reproduce this bug, in details: 1. Open konsole; 2. In the menu open: "Bookmarks" -> "Edit bookmarks..."; 3. Add new bookmark with following properties: Name: "Test date command" Location: "date +%m-%d-%Y" 4. Close bookmark window; 5. Select new bookmark in the menu: "Bookmarks" -> "Test date command" (on the bottom); You will see this output: $ date +%25m-%25d-%25Y 0000000000000000000000004-0000000000000000000000030-0000000000000000000002020 Instead of this (correct behaviour): $ date +%m-%d-%Y 04-30-2020 Notice that every '%' symbol got replaced with '%25'. Created attachment 128020 [details]
Visual representation of the bug
Created attachment 128021 [details]
konsole_fix_bookmark_command_being_percent_encoded.patch
Created attachment 128022 [details]
konsole_fix_bookmark_command_being_percent_encoded.patch
Sorry, wrong patch
Git commit d3519ae24c0de218b3a2c0728fb4da519574044a by Kurt Hindenburg, on behalf of Yaroslav Sidlovsky. Committed on 03/05/2020 at 01:59. Pushed by hindenburg into branch 'master'. Use Qurl::fromPercentEncoding for bookmarks This will allow % in URLs; also sync test code with actual code. Previously the tests were using toUtf8(); however fromPercentEncoding seems better. Differential Revision: https://phabricator.kde.org/D29322 M +2 -1 src/SessionController.cpp M +4 -4 src/autotests/BookMarkTest.cpp https://invent.kde.org/kde/konsole/commit/d3519ae24c0de218b3a2c0728fb4da519574044a Git commit 35ff3a72cefea944000d166a7919291e74e03d9e by Kurt Hindenburg, on behalf of Yaroslav Sidlovsky. Committed on 05/05/2020 at 00:52. Pushed by hindenburg into branch 'release/20.04'. Use Qurl::fromPercentEncoding for bookmarks This will allow % in URLs; also sync test code with actual code. Previously the tests were using toUtf8(); however fromPercentEncoding seems better. Differential Revision: https://phabricator.kde.org/D29322 (cherry picked from commit d3519ae24c0de218b3a2c0728fb4da519574044a) M +2 -1 src/SessionController.cpp M +4 -4 src/autotests/BookMarkTest.cpp https://invent.kde.org/kde/konsole/commit/35ff3a72cefea944000d166a7919291e74e03d9e |