Bug 420634

Summary: Face thumbnails not zoomed in and have wrong orientation on network shares
Product: [Applications] digikam Reporter: Benny <jff2k>
Component: Faces-WorkflowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: metzpinguin
Priority: NOR    
Version: 7.0.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In: 7.0.0
Sentry Crash Report:
Attachments: Screenshot of face thumbnails in digiKam 7.0.0-rc
Screenshot of face thumbnails and metadata

Description Benny 2020-04-26 19:29:28 UTC
Created attachment 127901 [details]
Screenshot of face thumbnails in digiKam 7.0.0-rc

Thumbnails are not correctly created or shown in digiKam 6.4.0 or 7.0.0-rc when using "Collections on Network Shares". Some thumbails are zoomed in to the recognized face, but most of the thumbnails just show the whole picture and the thumbnails are not updated, when the face region is changed, edited or the picture is edited or rotated.


STEPS TO REPRODUCE
1. Use "Collections on Network Shares" and wait until digikam finishes thumbnail creation
2. Go to People and select an album
3. Have a look at the thumbnails

OBSERVED RESULT
Thumbnails of peoples show the whole picture and not only the zoomed in view of the face region. Rotated images (exif) are displayed in wrong orientation (in the normal album the same picture is shown correctly even in the thumbnail view).

EXPECTED RESULT
Show the face region only, use the exif orientation tag to show the correct orrientation.

SOFTWARE/OS VERSIONS
Windows: 10 1909

FURTHER INFORMATION
Just found that other digiKam-users have the same issue:
http://digikam.1695700.n4.nabble.com/digiKam-users-People-thumbnail-not-zoomed-to-face-td4709112.html
Comment 1 Maik Qualmann 2020-04-26 20:23:15 UTC
The problem must be specific to Windows. It cannot be reproduced here on Linux. Is the network collection connected to a drive letter? Or the "\\servername..." path is used? I suspect a basic problem reading the metadata of the images. Any special characters in the path / file name?

Maik
Comment 2 Maik Qualmann 2020-04-26 20:35:41 UTC
Yes, the reason is the use of "\\servername...". Exiv2 cannot read metadata. The metadata tab should also be empty for you. As I said, officially we say that digiKam requires the drive letter under Windows. I will see, maybe there is a solution...

Maik
Comment 3 Benny 2020-04-26 20:48:29 UTC
Created attachment 127905 [details]
Screenshot of face thumbnails and metadata

Hi Maik,

I use the share directly via \\servername\path and there are no special characters in the path. But metadata is correctly shown in digiKam, see screenshot.

Some faces had been recognized in another tool (picasa) and I'm now correcting them in digiKam - but the face thumbnails are not updated at all for the person-albums. In the normal albums the thumbnails are updated when I edit the pictures or for example change orientation.
Comment 4 Maik Qualmann 2020-04-27 06:15:12 UTC
Git commit 4af4a6e6ec07a8c1de8747f9f84bec88d72f77a7 by Maik Qualmann.
Committed on 27/04/2020 at 06:13.
Pushed by mqualmann into branch 'master'.

try using native path separators #1

M  +10   -7    core/libs/jpegutils/jpegutils.cpp
M  +3    -1    core/libs/metadataengine/engine/metaengine_comments.cpp
M  +3    -1    core/libs/metadataengine/engine/metaengine_exif.cpp
M  +4    -2    core/libs/metadataengine/engine/metaengine_fileio.cpp
M  +3    -1    core/libs/metadataengine/engine/metaengine_iptc.cpp
M  +8    -5    core/libs/metadataengine/engine/metaengine_p.cpp
M  +1    -0    core/libs/metadataengine/engine/metaengine_p.h
M  +2    -1    core/libs/metadataengine/engine/metaengine_previews.cpp
M  +4    -2    core/libs/metadataengine/engine/metaengine_xmp.cpp
M  +11   -7    core/libs/pgfutils/pgfutils.cpp
M  +3    -3    core/libs/threadimageio/engine/dfileoperations.cpp

https://invent.kde.org/kde/digikam/commit/4af4a6e6ec07a8c1de8747f9f84bec88d72f77a7
Comment 5 Maik Qualmann 2020-04-27 06:16:00 UTC
Gilles, would be nice if you could start Win64 Build again.

Best

Maik
Comment 6 Maik Qualmann 2020-04-28 16:18:56 UTC
Git commit 5bbca23b7e0aaacd4a41ab75d54ad271b221ad68 by Maik Qualmann.
Committed on 28/04/2020 at 16:17.
Pushed by mqualmann into branch 'master'.

fix detail thumbnails from UNC paths
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +1    -2    core/libs/threadimageio/thumb/thumbnailcreator.cpp

https://invent.kde.org/kde/digikam/commit/5bbca23b7e0aaacd4a41ab75d54ad271b221ad68
Comment 7 Benny 2020-04-28 19:16:16 UTC
Hi Maik, thank you very much for your really fast support!

sorry for asking, but is your fix already included in the most recent version at https://files.kde.org/digikam/ ?

I've installed "digiKam-7.0.0-rc-20200428T165414-Win64.exe" uploaded 28-Apr-2020 15:16 and the person thumbnails still don't show up correctly on Windows when using UNC-paths.

Benny
Comment 8 Maik Qualmann 2020-04-28 21:13:06 UTC
No not yet. Only in the next Windows build.

Maik
Comment 9 Benny 2020-04-29 18:52:27 UTC
Hi Maik,

I have to thank you again! Works perfectly with the latest RC "digiKam-7.0.0-rc-20200429T150011-Win64.exe".

Benny
Comment 10 Maik Qualmann 2020-04-30 06:02:06 UTC
Thanks for the feedback.

Maik