| Summary: | iso5426test fails (and maybe Iso5426Converter is broken) when char is unsigned | ||
|---|---|---|---|
| Product: | [Applications] tellico | Reporter: | Pino Toscano <pino> |
| Component: | general | Assignee: | Robby Stephenson <robby> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 3.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/tellico/ab305dd0d8b720c8e01dae8a66f6527442fb73f1 | Version Fixed In: | 3.3.1 |
| Sentry Crash Report: | |||
| Attachments: | Try to account for uchar from QByteArray | ||
|
Description
Pino Toscano
2020-04-23 10:21:01 UTC
Created attachment 127900 [details]
Try to account for uchar from QByteArray
You're right - I think I made multiple errors in the new code and then wrote incorrect unit tests that didn't catch it! I attached a patch - I'd appreciate if you'd let me know if this might fix it. I'm flying in the blind a little bit. (In reply to Robby Stephenson from comment #1) > Created attachment 127900 [details] > Try to account for uchar from QByteArray I tested this patch on s390x Debian unstable porterbox, and it worked -- iso5426test passed. Thanks! Git commit fd35c88321710d42b89cd9733140ad269fcd78a5 by Robby Stephenson. Committed on 26/04/2020 at 21:31. Pushed by rstephenson into branch 'master'. Use correct uchar cast for QByteARray in ISO-6937 converter Similar to fix in the ISO-5426 converter. It doesn't seem to be tested at all in the unit test. M +7 -7 src/utils/iso6937converter.cpp https://commits.kde.org/tellico/fd35c88321710d42b89cd9733140ad269fcd78a5 Git commit ab305dd0d8b720c8e01dae8a66f6527442fb73f1 by Robby Stephenson. Committed on 26/04/2020 at 21:29. Pushed by rstephenson into branch 'master'. Account for QByteArray::at returning char, not uchar Cast accordingly to uchar and fix the character combination code. In addition, correct all the unit tests where the incorrect comparisons were being done. FIXED-IN: 3.3.1 M +4 -0 ChangeLog M +127 -129 src/utils/iso5426converter.cpp https://commits.kde.org/tellico/ab305dd0d8b720c8e01dae8a66f6527442fb73f1 (In reply to Pino Toscano from comment #3) > (In reply to Robby Stephenson from comment #1) > > Created attachment 127900 [details] > > Try to account for uchar from QByteArray > > I tested this patch on s390x Debian unstable porterbox, and it worked -- > iso5426test passed. Thanks! Thanks! Thanks, it worked perfectly now: https://buildd.debian.org/status/logs.php?pkg=tellico&ver=3.3-2&suite=sid |