Bug 420437

SUMMARY

EKOS scheduler cannot handle the situation where at first it did image, then it closed down due to bad weather, and from this state with history it cannot start when weather clears up again.

Even worse, when the Twilight interval reaches the new evening, scheduler happily instructs the dome to open without noting that the weather is still in alert state. (Luckily the Dome device driver refuses to open due to bad weather). But when the weather later clears up Scheduler does not take action. (It should only then instruct the Dome to open).

Here's a log of this case :

2020-04-22T22:25:49 Weather conditions are OK.
2020-04-22T22:03:03 Unparking dome...
2020-04-22T22:03:01 Warning: job 'hd224992' execution overlaps daylight, it will be interrupted at dawn and rescheduled on next night time.
2020-04-22T22:03:00 Scheduler started.
2020-04-22T22:03:00 Scheduler is awake.
2020-04-22T06:15:16 Caution: weather conditions are in the DANGER zone!
2020-04-22T04:43:04 Shutdown complete.

So the observatory shut down this morning at 04:43, then just now at 22:03 it said 'Unparking Dome', which the Dome driver refused. At this point weather was still in alert state. Weather state cleared up 22 minutes later but that initiated no action.

The Dome Scripting Gateway log :

2020-04-22T22:03:03: [WARNING] Weather is in the danger zone! Cannot unpark dome.

STEPS TO REPRODUCE
- have weather and twilight boxes checked in the scheduler
- use a job that spans multiple nights
- let scheduler image
- let it close up
- let it run to the next evening

OBSERVED RESULT

- scheduler instructed the dome to open while weather was in alert state
- when weather cleared up nothing happened
- weather checkbox became greyed out the second evening

EXPECTED RESULT

- scheduler does not instruct dome to open when weather is in alert state
- scheduler continues imaging when weather clears up
- weather checkbox is not greyed out halfway a session

kstars-bleeding 6:3.4.1+202002231737~ubuntu18.04.1 on Ubuntu 18.04.4 LTS