| Summary: | Kontact window has wrong title | ||
|---|---|---|---|
| Product: | [Applications] kontact | Reporter: | Fabian Vogt <fabian> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | faure |
| Priority: | NOR | ||
| Version: | GIT (master) | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kontact/a62c89751bff05c87ed6aaa868d51bb38ba8c7e8 | Version Fixed In: | |
|
Description
Fabian Vogt
2020-04-21 06:35:08 UTC
I confirm, but I'm surprised that it's a regression (IOW I wonder how it ever worked). Does openQA have the information of what was the last version where it worked? (Qt5, KF5, kdepim -- I suspect the change was either in KF5 or in Qt5) Excellent GUI regression system you guys have, in any case. Oh, wait, I get it. The switch from KParts::ReadOnlyPart to KParts::Part made us lose the automatic caption handling that was happening in KParts::ReadOnlyPart::guiActivateEvent. How unexpected ;) Oh well, it's cleaner this way. I'll fix it. Git commit a62c89751bff05c87ed6aaa868d51bb38ba8c7e8 by David Faure. Committed on 23/04/2020 at 23:11. Pushed by dfaure into branch 'master'. Adjust caption handling after the switch from ReadOnlyPart to Part. KParts::ReadOnlyPart::guiActivateEvent is no longer called, so nothing clears the window title anymore. Just detect that the plugin didn't touch it. OpenQA rocks (as well as Fabian for submitting bug reports when OpenQA detects a regression). M +4 -3 src/mainwindow.cpp https://commits.kde.org/kontact/a62c89751bff05c87ed6aaa868d51bb38ba8c7e8 Confirmed fixed, thanks! https://openqa.opensuse.org/tests/1244145#step/kontact/15 |