Bug 420297

Summary:	building llvm test case broken
Product:	[Applications] umbrello	Reporter:	Ralf Habacker <ralf.habacker>
Component:	installer/packages	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	Git
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	https://invent.kde.org/kde/umbrello/commit/9ab35ae8f4408b16d437f3d6e2156c4a87afb78e	Version Fixed/Implemented In:	2.31.0 (KDE releases 20.04.0)
Sentry Crash Report:

Description Ralf Habacker 2020-04-19 09:28:57 UTC

KDE CI reported a build error at https://build.kde.org/job/Applications/job/umbrello/job/stable-kf5-qt5%20SUSEQt5.12/136/consoleFull

  from /usr/include/clang/Basic/ObjCRuntime.h:18,
18:43:39                   from /usr/include/clang/Basic/LangOptions.h:19,
18:43:39                   from /usr/include/clang/Frontend/FrontendAction.h:22,
18:43:39                   from /usr/include/clang/Frontend/FrontendActions.h:12,
18:43:39                   from /home/jenkins/workspace/Applications/umbrello/stable-kf5-qt5 SUSEQt5.12/unittests/testllvm.cpp:22:
18:43:39  /usr/include/llvm/ADT/STLExtras.h:559:49: error: std::index_sequence has not been declared
18:43:39    559 |   template <size_t... Ns> value_type deref(std::index_sequence<Ns...>) const {

STEPS TO REPRODUCE
1. no local reproduction possible, see above mentioned link

OBSERVED RESULT
build failure

EXPECTED RESULT
there should no build failure

SOFTWARE/OS VERSIONS
see above mentioned link

Comment 1 Ralf Habacker 2020-04-19 09:29:46 UTC

Git commit e4a220bf1ac63d8399ce33ff8ac1684404e9cd63 by Ralf Habacker.
Committed on 18/04/2020 at 05:15.
Pushed by habacker into branch 'release/20.04'.

unittests: only build llvm testcase with the supported versions 7 and 8

llvm changes api on each major release.

M  +5    -1    unittests/CMakeLists.txt

https://invent.kde.org/kde/umbrello/commit/e4a220bf1ac63d8399ce33ff8ac1684404e9cd63

Comment 2 Ralf Habacker 2020-04-19 09:31:47 UTC

Git commit 0949905835fcf6d580e6c81cebd958b9650b93d7 by Ralf Habacker.
Committed on 18/04/2020 at 05:24.
Pushed by habacker into branch 'release/20.04'.

unittests: fix checking llvm version number

M +1 -1 unittests/CMakeLists.txt

invent.kde.org/kde/umbrello/commit/0949905835fcf6d580e6c81cebd958b9650b93d7

diff --git a/unittests/CMakeLists.txt b/unittests/CMakeLists.txt
index fd3ed4a67..743bbaba5 100644
--- a/unittests/CMakeLists.txt
+++ b/unittests/CMakeLists.txt
@@ -168,7 +168,7 @@ if(LLVM_FOUND AND (Clang_FOUND OR CLANG_FOUND))
message(STATUS "Using LLVMConfig.cmake in: ${LLVM_DIR}")

message(STATUS "Found CLANG ${CLANG_PACKAGE_VERSION}")
- if(LLVM_PACKAGE_VERSION VERSION_LOWER_EQUAL "8.0.0")
+ if(LLVM_PACKAGE_VERSION VERSION_LOWER "9.0.0")
set(ENABLE_LLVM_TESTCASES 1)
endif()
endif()

Comment 3 Ralf Habacker 2020-04-19 09:32:26 UTC

Git commit 9ab35ae8f4408b16d437f3d6e2156c4a87afb78e by Ralf Habacker.
Committed on 18/04/2020 at 10:26.
Pushed by habacker into branch 'release/20.04'.

cmake: fix version compare lower syntax

M +1 -1 unittests/CMakeLists.txt

invent.kde.org/kde/umbrello/commit/9ab35ae8f4408b16d437f3d6e2156c4a87afb78e

diff --git a/unittests/CMakeLists.txt b/unittests/CMakeLists.txt
index 743bbaba5..08cd43ab7 100644
--- a/unittests/CMakeLists.txt
+++ b/unittests/CMakeLists.txt
@@ -168,7 +168,7 @@ if(LLVM_FOUND AND (Clang_FOUND OR CLANG_FOUND))
message(STATUS "Using LLVMConfig.cmake in: ${LLVM_DIR}")

message(STATUS "Found CLANG ${CLANG_PACKAGE_VERSION}")
- if(LLVM_PACKAGE_VERSION VERSION_LOWER "9.0.0")
+ if(LLVM_PACKAGE_VERSION VERSION_LESS "9.0.0")
set(ENABLE_LLVM_TESTCASES 1)
endif()
endif()