Bug 420256

Summary:	Searching for "All" (= both open and closed bugs) in the search form yields an error
Product:	[Websites] bugs.kde.org	Reporter:	Shlomi Fish <shlomif>
Component:	general	Assignee:	KDE sysadmins <sysadmin>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bcooksley, sheedy
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/websites/bugs-kde-org/63b327e62ca2118552690f71071e4b7f8dfc3ded	Version Fixed/Implemented In:
Sentry Crash Report:

Description Shlomi Fish 2020-04-18 14:53:48 UTC

STEPS TO REPRODUCE
1. Go to https://bugs.kde.org/query.cgi 
2. Set status to "All".
3. Type in "Words" : "konsole" (or whatever)
4. Press the "Search" button.

Goes to https://bugs.kde.org/buglist.cgi?query_format=specific&order=Importance&no_redirect=1&bug_status=__all__&product=&content=konsole and says:


OBSERVED RESULT

```

KDE Bugtracking System – Parameters Required
You may not search, or create saved searches, without any search terms.

Please press Back and try again.
```


EXPECTED RESULT

Displays the search.


Happens in a new firefox profile too.

Comment 1 Ben Cooksley 2020-04-18 21:02:13 UTC

Git commit 63b327e62ca2118552690f71071e4b7f8dfc3ded by Ben Cooksley.
Committed on 18/04/2020 at 21:02.
Pushed by bcooksley into branch 'kde-5.0'.

Use the correct comparison operator to ensure we do what we were expecting to do.

M  +1    -1    buglist.cgi

https://commits.kde.org/websites/bugs-kde-org/63b327e62ca2118552690f71071e4b7f8dfc3ded

Comment 2 Shlomi Fish 2020-04-19 06:42:09 UTC

(In reply to Ben Cooksley from comment #1)
> Git commit 63b327e62ca2118552690f71071e4b7f8dfc3ded by Ben Cooksley.
> Committed on 18/04/2020 at 21:02.
> Pushed by bcooksley into branch 'kde-5.0'.
> 
> Use the correct comparison operator to ensure we do what we were expecting
> to do.
> 
> M  +1    -1    buglist.cgi
> 
> https://commits.kde.org/websites/bugs-kde-org/
> 63b327e62ca2118552690f71071e4b7f8dfc3ded

Thanks for the fix! It seems fine now.

Have you also written and deployed a regression test? https://en.wikipedia.org/wiki/Test_automation .

Comment 3 Ben Cooksley 2020-04-19 08:35:10 UTC

I'm afraid not - the code change in question was a patch to fix an SQL error being thrown in our setup and Bugzilla in general is software that we just take from upstream.