Bug 420215

Summary: Video size isn't propagated to ffmpeg in case of GIF
Product: [Applications] krita Reporter: Tiar <tamtamy.tymona>
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/krita/commit/7647f6529acd6cbba6a455c04822ca8d610f3687 Version Fixed In:
Sentry Crash Report:

Description Tiar 2020-04-17 19:22:52 UTC 
SUMMARY
Video size in Render Animation dialog is ignored in case of gifs.


STEPS TO REPRODUCE
1. Create an animation.
2. In Render Animation dialog put size that is twice smaller.
3. Render animation as both gif and mp4.

OBSERVED RESULT
Gif size is the original size. Mp4 size is the scaled size.

EXPECTED RESULT
Video size is respected, OR it's communicated clearly to the user that it's not possible if it's not possible. (Although it really should be).


SOFTWARE/OS VERSIONS
rita

 Version: 4.2.9
 Languages: pl, pl_PL, pl
 Hidpi: true

Qt

  Version (compiled): 5.12.7
  Version (loaded): 5.12.7

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 5.3.7-050307-generic
  Pretty Productname: Linux Mint 19.3
  Product Type: linuxmint
  Product Version: 19.3
Comment 1 Ahab Greybeard 2020-04-23 12:03:01 UTC 
When I have a 2048 x 2048 animation that I try to render as a 1024 x 1024 animated .gif output the following lines are shown in log_encode_gif.log:

Reading option '-vf' ... matched as option 'vf' (set video filters) with argument 'scale=w=1024:h=1024:force_original_aspect_ratio=decrease'
Trailing options were found on the commandline.

That does not appear if I render with size = 2048 x 2048.

Is ffmpeg being provided with all the required options with the correct syntax?

Setting to Confirmed
Comment 2 vanyossi 2020-04-27 07:24:36 UTC 
Git commit 3efcd3e648c62b017b3146b9efb6826d6d1aaa0d by Ivan Yossi.
Committed on 27/04/2020 at 07:16.
Pushed by ivany into branch 'master'.

Fix ffmpeg argument construct for GIF save

M  +7    -3    plugins/extensions/animationrenderer/video_saver.cpp

https://invent.kde.org/kde/krita/commit/3efcd3e648c62b017b3146b9efb6826d6d1aaa0d
Comment 3 Halla Rempt 2020-06-24 11:53:09 UTC 
Git commit 7647f6529acd6cbba6a455c04822ca8d610f3687 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 24/06/2020 at 11:52.
Pushed by rempt into branch 'krita/4.3'.

Fix ffmpeg argument construct for GIF save
Related: bug 423439
(cherry picked from commit 3efcd3e648c62b017b3146b9efb6826d6d1aaa0d)

M  +7    -3    plugins/extensions/animationrenderer/video_saver.cpp

https://invent.kde.org/graphics/krita/commit/7647f6529acd6cbba6a455c04822ca8d610f3687