Summary: | drkonqi UI issues in Wayland session | ||
---|---|---|---|
Product: | [Applications] drkonqi | Reporter: | Andreas Sturmlechner <asturm> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, nate |
Priority: | NOR | ||
Version: | 5.18.4 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/drkonqi/262389b1e49ba12f6d8df8db71e350fb62698c3e | Version Fixed In: | |
Sentry Crash Report: |
Description
Andreas Sturmlechner
2020-04-13 14:15:27 UTC
Second issue was already reported, see bug 418755. Git commit 262389b1e49ba12f6d8df8db71e350fb62698c3e by David Edmundson. Committed on 14/04/2020 at 16:48. Pushed by davidedmundson into branch 'Plasma/5.18'. Avoid creating subwindow on internal page widget Summary: KWallet::openWallet takes a windowId as a parameter. QWidget->winId() is a dangerous call, it will create an underlying platform window when called. This happens even if we're not the toplevel widget. On X11 this passed winId must have always been broken, but not in a way that caused a problem. This leaves QtWayland in a very confused state with the side effect that all scrolling widgets become broken. Related: bug 418755 Test Plan: Bisected drkonqi till we found the cause Verified fix by running crashtest (with some mods so I could report a bug) I can't confirm the winId is correct on X11, but the code looks safe Reviewers: #plasma, sitter Reviewed By: sitter Subscribers: sitter, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28832 M +10 -2 src/bugzillaintegration/reportassistantpages_bugzilla.cpp https://commits.kde.org/drkonqi/262389b1e49ba12f6d8df8db71e350fb62698c3e |