Summary: | Blur Filters create artifacts that are revealed by splitting the alpha out | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Ahab Greybeard <ahab.greybeard> |
Component: | Filters | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, griffinvalley |
Priority: | NOR | ||
Version: | nightly build (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Debian stable | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/a3b71748b5c3a3ce57345568617e511598d6ea62 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | Example image of artifacts |
Description
Ahab Greybeard
2020-04-13 08:38:55 UTC
Indeed it does... I think what is going on is that those paintdevices aren't being initialized fully before anything is drawn on them. Git commit fd0e0ff83d0c3b3d5e18de96d3c56a53544b6291 by Dmitry Kazakov. Committed on 28/08/2020 at 11:13. Pushed by dkazakov into branch 'krita/4.3'. Fix artifacts when doing Split Alpha after Gaussian Blur filter After applying gaussian we should not write color values into the destination device if alpha channel is null. There had already been such check, but it checked for null in 'double' space, not in the space of the destination device (which is usually 'quint8') M +29 -7 libs/image/kis_convolution_worker_fft.h M +52 -0 libs/image/kis_math_toolbox.cpp M +2 -0 libs/image/kis_math_toolbox.h https://invent.kde.org/graphics/krita/commit/fd0e0ff83d0c3b3d5e18de96d3c56a53544b6291 Git commit a3b71748b5c3a3ce57345568617e511598d6ea62 by Dmitry Kazakov. Committed on 28/08/2020 at 11:34. Pushed by dkazakov into branch 'master'. Fix artifacts when doing Split Alpha after Gaussian Blur filter After applying gaussian we should not write color values into the destination device if alpha channel is null. There had already been such check, but it checked for null in 'double' space, not in the space of the destination device (which is usually 'quint8') M +29 -7 libs/image/kis_convolution_worker_fft.h M +52 -0 libs/image/kis_math_toolbox.cpp M +2 -0 libs/image/kis_math_toolbox.h https://invent.kde.org/graphics/krita/commit/a3b71748b5c3a3ce57345568617e511598d6ea62 |