Bug 420010

Summary:	konqueror + kf 5.69: Crash when opening bookmark folder
Product:	[Applications] konqueror	Reporter:	Markus <m4rkusxxl>
Component:	bookmarks	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	a.samirh78, asturm, dolgener, rdieter, wbauer1
Priority:	NOR	Keywords:	regression
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=419981
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Crash report Patch for konqbookmarkmenu in kbookmarks 5.69 Patch for konqbookmarkbar in konqueror-19.12.3

Description Markus 2020-04-13 06:06:48 UTC

SUMMARY
I have some bookmarks organized in folder. When I open such a folder (either in the bookmark bar or in bookmark menu) konqueror will crash.

STEPS TO REPRODUCE
1. Create a bookmark folder.
2. Try to open in bar or menu.

OBSERVED RESULT
Konqueror crashs.

EXPECTED RESULT
Open the bookmark folder.

SOFTWARE/OS VERSIONS
Linux: Gentoo
KDE Plasma Version: 5.18.4.1
KDE Frameworks Version: 5.69.0
KDE Applications Version: 19.12.3
Qt Version: 5.14.1

Comment 1 Markus 2020-04-13 06:14:59 UTC

Created attachment 127485 [details]
Crash report

Comment 2 Andreas Sturmlechner 2020-04-13 14:43:40 UTC

Please try the patch from commit https://cgit.kde.org/konqueror.git/commit/?id=078f357bc7f318509902dda9b6ec79a12df25427

Comment 3 Markus 2020-04-13 16:07:19 UTC

Thanks for the patch.
I had to adapt it and apply it to kbookmarks. (konqueror from kapps 19.12.3 does not yet include it.)

Now the bookmark menu works.

But the folders in the bookmark bar still cause a crash.

Comment 4 Andreas Sturmlechner 2020-04-13 19:56:04 UTC

There's another pending fix for KBookmarks: https://phabricator.kde.org/D28800

(In reply to Markus from comment #3)
> Thanks for the patch.
> I had to adapt it and apply it to kbookmarks. (konqueror from kapps 19.12.3
> does not yet include it.)

Would you mind sharing?

Comment 5 Markus 2020-04-14 06:00:30 UTC

Created attachment 127526 [details]
Patch for konqbookmarkmenu in kbookmarks 5.69

Comment 6 Markus 2020-04-14 06:22:49 UTC

Created attachment 127527 [details]
Patch for konqbookmarkbar in konqueror-19.12.3

Comment 7 Markus 2020-04-14 06:25:01 UTC

The last patch also fixes the crash when opening a folder in the bookmark bar.
I tried to adapt the konqbookmarkmenu patch to the bar, so I am not sure if its a clean solution.

Comment 8 Ahmad Samir 2020-04-18 09:28:12 UTC

Could you try with konqueror master? I see two commits addressing the issue there already: 
https://cgit.kde.org/konqueror.git/commit/?id=078f357bc7f318509902dda9b6ec79a12df25427
https://cgit.kde.org/konqueror.git/commit/?id=b61086cfece0d0f11ecfe9c3309697997cada201

Comment 9 Ahmad Samir 2020-04-23 10:59:41 UTC

*** Bug 420366 has been marked as a duplicate of this bug. ***

Comment 10 Wolfgang Bauer 2020-04-24 06:44:02 UTC

The crash is also fixed by this commit in kbookmarks:
https://cgit.kde.org/kbookmarks.git/commit/?id=4b3fc2aedd86505a47b9b185e086ef253e73ede8

Comment 11 Markus 2020-04-27 09:15:52 UTC

Seems fixed in 20.04.