Bug 419827

Summary:	Reload original preset doesn't work
Product:	[Applications] krita	Reporter:	Yu-Hsuan Lai <raincolee>
Component:	Resource Management	Assignee:	Halla Rempt <halla>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard, kerogii, tomtomtomreportingin
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Yu-Hsuan Lai 2020-04-08 05:19:52 UTC

SUMMARY
The "Reload Original Preset" button on the toolbar doesn't work at all.

STEPS TO REPRODUCE
1. Open a file with Krita
2. Select a brush from Brush Presets docker
3. Change the size of brush
4. Press "Reload Original Preset" button on the toolbar

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
The brush size is reset to the original preset's size


SOFTWARE/OS VERSIONS
macOS: 10.14.6
Krita: Nightly build. Git commit 5a1f66f


ADDITIONAL INFORMATION
 this problem doesn't occur in Krita 4.2.9 (the latest stable version)

Comment 1 Ahab Greybeard 2020-04-08 14:33:43 UTC

I can confirm this for appimages as follows:

4.2.9: does not happen
4.3.0 prealpha git 9a24cf0 (18 Mar): does not happen
4.3.0 prealpha git 66b65ab (26 Mar): it happens
5.0.0 prealpha git 78d1d45 (08 Apr): it happens

A brush preset in this condition is marked as dirty in the brush presets docker but can not be selected from the brush presets docker or the brush preset history docker.
All goes back to normal after a restart.
Setting to Confirmed

Comment 2 tomtomtomreportingin 2021-04-03 10:59:14 UTC

Somehow got a crash when I hit the Reload Original Preset, but I haven't been able to reproduce it. I also forgot to save the safe assert that could have caused it, and all I could remember was that it was resource related.

Comment 3 Halla Rempt 2021-04-08 13:53:16 UTC

This works for me, with be5f1e7035. A crash or assert should probably be reported as a separate bug, and without backtrace we can't do much here.