Bug 419791

Summary: Layer thumbnails have the wrong aspect ratio
Product: [Applications] krita Reporter: Halla Rempt <halla>
Component: UsabilityAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard, tamtamy.tymona
Priority: NOR Keywords: regression
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Wrong aspect ratio
correct aspect ratio
Wrong and correct thumbs aspect ratio

Description Halla Rempt 2020-04-07 12:48:29 UTC
Created attachment 127349 [details]
Wrong aspect ratio

I'm using the file from bug https://bugs.kde.org/show_bug.cgi?id=419715 

With Krita 4.2.0-preview, the thumbnails for the layers with the color blocks have the right aspect ration. From 4.2.0 on, the aspect ration is distorted.
Comment 1 Halla Rempt 2020-04-07 12:48:49 UTC
Created attachment 127350 [details]
correct aspect ratio
Comment 2 Ahab Greybeard 2020-04-08 11:04:48 UTC
Created attachment 127383 [details]
Wrong and correct thumbs aspect ratio

I can confirm this for the 4.2.9 appimage and the 01 April Nightly build appimage.

I attach Layer-Thumbs-Aspect-Ratio.png which shows both conditions and indicates that it's content dependent in some way.
(Adding another red rectangle will send the Layer 1 thumbnail into a vertically stretched condition, like Layer 2.

Setting to Confirmed
Comment 3 Halla Rempt 2020-05-06 16:37:00 UTC
This really needs to be fixed...
Comment 4 Tiar 2020-05-06 17:03:24 UTC
David Revoy gave us a bit of a tip when the regression happened:

> boud: dmitryK|log : From my screenshot of Krita GUI while making Pepper&Carrot; the layer ratio thumbnails regression happened between 4.2.5 and 4.2.6 (around April/May/June/jully 2019). Sorry to can't be more precise.
eg. https://www.davidrevoy.com/data/images/blog/2019

> /ep29/2019-04-18_screenshot_142122_net.jpg (4.2.5) the ratio of page reflect on thumbnail in layer stack

> while 16 jully: https://www.davidrevoy.com/data/images/blog/2019/2019-07-16_screenshot_151926_net.jpg , all square layer thumbnails
Comment 5 Dmitry Kazakov 2020-05-06 19:17:29 UTC
I think the offending commit is this one:
097d7e617aa260d467f86e65f8c6edfdd6124ea9
Comment 6 Dmitry Kazakov 2020-05-06 19:40:52 UTC
The bug is fixed in 

https://invent.kde.org/kde/krita/commit/4d9ef037b1f27ead0b94b46407971c2b9112a326