Summary: | trying to change POP3 resource crashes | ||
---|---|---|---|
Product: | [Frameworks and Libraries] Akonadi | Reporter: | Martin Koller <kollix> |
Component: | POP3 Resource | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aacid, bugrprt21882, gianogli |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kdepim-runtime/6cdf43de73993cb4615844b3461078e9e1bef467 | Version Fixed In: | 20.08.0 |
Sentry Crash Report: |
Description
Martin Koller
2020-04-06 14:57:12 UTC
Works fine here, can you run under valgrind to see if you get any interesting log? Git commit 6cdf43de73993cb4615844b3461078e9e1bef467 by Daniel Vrátil. Committed on 10/04/2020 at 21:58. Pushed by dvratil into branch 'master'. POP3: Remove the singleton pattern from Settings Summary: It's causing issues with the "new" out-of-process settings dialog which initializes a new Settings object each time and asserts when the SettingsHelper Q_GLOBAL_STATIC is already initialized. Instead just get rid of the singleton pattern and have Settings object be owned by whomever created it and pass a reference to it to the classes that need it. Subscribers: mkoller, kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D28732 M +58 -57 resources/pop3/accountwidget.cpp M +4 -1 resources/pop3/accountwidget.h M +10 -9 resources/pop3/jobs.cpp M +3 -1 resources/pop3/jobs.h M +8 -8 resources/pop3/pop3config.cpp M +47 -46 resources/pop3/pop3resource.cpp M +4 -0 resources/pop3/pop3resource.h M +6 -31 resources/pop3/settings.cpp M +10 -2 resources/pop3/settings.h https://commits.kde.org/kdepim-runtime/6cdf43de73993cb4615844b3461078e9e1bef467 *** Bug 424114 has been marked as a duplicate of this bug. *** *** Bug 425629 has been marked as a duplicate of this bug. *** *** Bug 429773 has been marked as a duplicate of this bug. *** *** Bug 429697 has been marked as a duplicate of this bug. *** |