| Summary: | Allow closing the Discover window during install and showing a progress notification instead | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | dagobertram |
| Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | aleixpol, giecrilj, nate |
| Priority: | NOR | ||
| Version: | 5.18.4 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/commit/5751e862556f8ee17ea0af60b8e0959559b90b6d | Version Fixed In: | 5.26 |
| Sentry Crash Report: | |||
| Attachments: | Discover "blocks" the task bar since there is less free space | ||
|
Description
dagobertram
2020-04-04 09:32:28 UTC
Why not just minimize it? The use case of "I want to get rid of this window from my view without actually quitting the application" is what window minimization is for, no? Well then I would have to come back to Discover and check if everything got installed. Meanwhile Discover blocks my task bar despite I finished everything I wanted it to start doing. After it finished successfully I finally can close it. Why not make it possible to preempt this step? It would be a significant usability improvement, at least for me. What do you mean by "Discover blocks my task bar"? Created attachment 127578 [details]
Discover "blocks" the task bar since there is less free space
I'm sorry english is not my first language ... Maybe it is called the task switcher? It just takes up space, where other windows might sit. I just attached a screenshot which might help describing. Oh I see, it just takes up space. How about this: while the update notifier is displayed and updates are in progress, Discover will allow you to close its main window but remain running. If you do this, when the update completes successfully, it will display a notification about this. If it fails, it will display a persistent notification mentioning the failure that prompts you to re-open the main window. Sounds really nice!
What do you think about turning the task itself into a notification? Similar to the one for copying files. It could show the progress while it is doing stuff. And then ...
> ... when the update completes successfully, it will display a notification about > this. If it fails, it will display a persistent notification mentioning the
> failure that prompts you to re-open the main window.
You could even make it possible to click the notification at any time to re-open Discover.
But how to integrate that behavior with the existing one for "hitting the »x«" (Bug 403465)? How are you supposed to stop the installation process instantly? (In reply to dagobertram from comment #8) > Sounds really nice! > What do you think about turning the task itself into a notification? Similar > to the one for copying files. It could show the progress while it is doing > stuff. And then you could even make it possible to click the notification at any > time to re-open Discover. I think that's a great idea! (In reply to dagobertram from comment #9) > But how to integrate that behavior with the existing one for "hitting the > »x«" (Bug 403465)? How are you supposed to stop the installation process > instantly? With the above proposal, you would be able to cancel immediately using the Stop button on the notification. (In reply to Nate Graham from comment #10) > With the above proposal, you would be able to cancel immediately using the > Stop button on the notification. Nice! Thank you for your support and dedication. I think it's awesome to see theory slowly becoming reality! Heh, you're very welcome! Of cource, now somebody needs to do it. :) (In reply to Nate Graham from comment #12) > Heh, you're very welcome! Of cource, now somebody needs to do it. :) I know. Well, I just started to learn basic python but I guess Qt/C++, QML etc. are quite a different story ... I have no experience in these languages whatsoever so I am happy to wait. ;D (... Maybe there are really easy Python problems somewhere in the KDE world ready to get solved? I really would like to get more involved.) I'm afraid we don't do much with Python, but C++ isn't such a bear. :) I started contributing code before I really had any idea what I was doing in C++. It's a time-honored tradition in fact! If you want some ideas, check out https://community.kde.org/Goals/Usability_%26_Productivity *** Bug 454196 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/308 Git commit 5751e862556f8ee17ea0af60b8e0959559b90b6d by Aleix Pol. Committed on 24/05/2022 at 16:12. Pushed by apol into branch 'master'. Do not prevent closing the main window while busy Instead now we will hide the main window and let discover finish performing the remaining transactions in the background. Thus, now when we close we will: - Hide the main window - Show a SNI to restore the window - Expose the transaction state in KUiServerJobTracker M +1 -2 CMakeLists.txt M +2 -0 discover/CMakeLists.txt M +83 -5 discover/DiscoverObject.cpp M +5 -1 discover/DiscoverObject.h M +3 -3 discover/qml/DiscoverWindow.qml M +4 -3 libdiscover/backends/DummyBackend/DummyTransaction.cpp https://invent.kde.org/plasma/discover/commit/5751e862556f8ee17ea0af60b8e0959559b90b6d |