Bug 419481

Summary:	kimap installs stuff conditional on BUILD_TESTING flag
Product:	[Frameworks and Libraries] kimap	Reporter:	Harald Sitter <sitter>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	montel
Priority:	NOR
Version:	git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:

Description Harald Sitter 2020-04-01 09:39:42 UTC

I can throw together a diff but am not sure what the intended behavior here is...

When building kimap without cmake BUILD_TESTING it installs fewer files than when with BUILD_TESTING.

STEPS TO REPRODUCE
1. cmake -DBUILD_TESTING=OFF
2. make install

OBSERVED RESULT
missing libkimaptest.a + headers

EXPECTED RESULT
Installed files should be the same.
That is to say either libkimaptest is meant to be used by other software built on top of kimap, in which case whether kimap was built with BUILD_TESTING or not should make no difference, OR libkimaptest is purely internal and shouldn't be installed at all.

Option 1:
Move kimaptest out of autotests dir so it always gets built and installed. So other software can use it.

Option 2:
Remove the install() calls.

Comment 1 Laurent Montel 2020-04-01 10:24:17 UTC

hi,
it's used in kdepim-runtime.
But by default if we build without BUILD_TESTING kimap we will build kdepim-runtime too without BUILD_TESTING

We have a test in kdepim-runtime "if(NOT TARGET KF5::kimaptest)"
So for me it's not a bug.
Regards