Bug 419455

Summary: Old C++ style foreach https://github.com/KDE/kmix/blob/master/apps/kmix.cpp#L426
Product: [Applications] kmix Reporter: ziadxkabakibi
Component: generalAssignee: Christian Esken <esken>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: https://invent.kde.org/multimedia/kmix/commit/c11e07bd42f2fb64cb66e2c4ea5c65e85722c5d3 Version Fixed/Implemented In:
Sentry Crash Report:

Description ziadxkabakibi 2020-03-31 14:54:18 UTC 
Foreach loop in line 426
can be transformed into :
for (const auto it : mixerViews)
which is safer and better as C++11 style
Comment 1 Christoph Feck 2020-04-15 08:21:21 UTC 
Please propose patches to our patch review site.

For more information, please see https://community.kde.org/Get_Involved/development
Comment 2 Jonathan Marten 2021-02-11 11:34:04 UTC 
Git commit c11e07bd42f2fb64cb66e2c4ea5c65e85722c5d3 by Jonathan Marten.
Committed on 10/02/2021 at 16:55.
Pushed by marten into branch 'master'.

Port deprecated foreach and Q_FOREACH -> for

M  +11   -11   apps/kmix.cpp
M  +6    -6    backends/mixer_alsa9.cpp
M  +2    -4    backends/mixer_backend.cpp
M  +2    -2    backends/mixer_mpris2.cpp
M  +3    -2    backends/mixer_oss.cpp
M  +2    -3    core/MediaController.cpp
M  +5    -5    core/mixdevice.cpp
M  +6    -6    core/mixer.cpp
M  +8    -8    core/mixset.cpp
M  +4    -9    core/volume.cpp
M  +1    -2    core/volume.h
M  +1    -1    dbus/dbusmixerwrapper.cpp
M  +1    -2    dbus/dbusmixsetwrapper.cpp
M  +4    -1    gui/dialogchoosebackends.cpp
M  +3    -3    gui/dialogviewconfiguration.cpp
M  +2    -2    gui/guiprofile.cpp
M  +2    -5    gui/kmixerwidget.cpp
M  +16   -18   gui/viewbase.cpp
M  +2    -2    gui/viewsliders.cpp
M  +59   -35   plasma/engine/mixerengine.cpp

https://invent.kde.org/multimedia/kmix/commit/c11e07bd42f2fb64cb66e2c4ea5c65e85722c5d3