Bug 419413

Summary:	Palette docker's swatch is lost forever if the palette's Column Count is set smaller than its position
Product:	[Applications] krita	Reporter:	Tyson Tan <tysontanx>
Component:	Dockers	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	normal	CC:	griffinvalley
Priority:	NOR
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Tyson Tan 2020-03-30 12:52:56 UTC

In our documentation of the Palette docker:
https://docs.krita.org/en/reference_manual/dockers/palette_docker.html

It says:

Column Count

    The amount of columns in this palette. This counts for all entries. If you accidentally make it smaller than the amount of entries that take up columns, you can still make it bigger until the next restart of Krita.

###

In reality, if you put a color to column 18, then change the palette's Column Count to 17, that color swatch on column 18 is gone forever. It's not listed in the color droplist anymore, it's not coming back after you change the palette's column count back to 18. Restarting Krita is not going to help either. So what's point of telling the user to "make it bigger until the next restart of Krita"? I'm translating this and it confused the glob out of me.

I don't know whether this is intended or not. If it is intended, then it's a very dangerous feature which can easily destroy people's palettes. We should warn the user about it when incompatible new column count is detected. The documentation's "If you accidentally make it smaller..." should be changed to "WARNING: If you accidentally make it smaller...the swatches outside will be lost forever!"

Tested on: krita-4.3.0-prealpha-aad2969-x86_64

Comment 1 Tyson Tan 2020-03-30 13:13:20 UTC

BTW this happens also when changing the palette's Row Count.

Comment 2 wolthera 2020-04-24 12:25:04 UTC

Yeah, I had been wondering about it as well when this was implemented :|

Comment 3 wolthera 2021-04-07 15:44:43 UTC

Git commit 2914f5986d56202a516b76e91a1112d60b65e091 by Wolthera van Hövell tot Westerflier.
Committed on 07/04/2021 at 15:44.
Pushed by woltherav into branch 'master'.

Move otherwise deleted swatches to their own row when resizing the palette.

This still doesn't solve the problem of rows resizing, but solving that will
require the whole code to be rewritten from scratch because the code in
question is fundamentally not designed for this.

M  +24   -0    libs/pigment/resources/KisSwatchGroup.cpp

https://invent.kde.org/graphics/krita/commit/2914f5986d56202a516b76e91a1112d60b65e091