| Summary: | Passive notifications lack padding when using Plasma style | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Nicolas Fella <nicolas.fella> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | Master | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kirigami/commit/cd9bef528dc1b8614ac9db70455fafb156ac7fe7 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
Git commit cd9bef528dc1b8614ac9db70455fafb156ac7fe7 by Nicolas Fella. Committed on 08/08/2020 at 14:04. Pushed by nicolasfella into branch 'master'. [passivenotification] Set explicit padding It currently relies on Control having an implicit padding in qqc2-desktop-style (https://invent.kde.org/frameworks/qqc2-desktop-style/-/blob/master/org.kde.desktop/Control.qml#L23). PC3 Control does not have this implicit padding (and I'm not sure what the implications of adding it would be). This results in the notification not having proper padding when using the Plasma QQC2 style. The resulting padding is 6 on my machine, which is neither smallSpacing (4) nor largeSpacing (8). I think it's better to use the existing units, but it results in a visual change. Therefore CC @teams/vdg M +5 -0 src/controls/templates/private/PassiveNotification.qml https://invent.kde.org/frameworks/kirigami/commit/cd9bef528dc1b8614ac9db70455fafb156ac7fe7 |
Created attachment 127094 [details] Screenshot When running apps with Plasma as QQC2 style passive notifications needs some left/right padding. See screenshot