| Summary: | Advanced color selector not closing on keyboard inputs | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Wojtek Trybus <wojtryb> |
| Component: | Color Selectors | Assignee: | wolthera <griffinvalley> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ghevan, griffinvalley, halla, lynx.mw+kde |
| Priority: | NOR | Keywords: | regression |
| Version: | 4.2.9 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/4211ee84216dafb078539eefebcbfa85521c7fc7 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Wojtek Trybus
2020-03-27 18:30:59 UTC
setting this to wishlist (In reply to wolthera from comment #1) > setting this to wishlist Of course, thank you, and sorry for the trouble. I made the bug report as Tiar asked me to on Krita-artists - according to Linx3d it was a change made by Ivan Yossi to fix another issue, and I thought it was probably unintended. Anyway it is not that severe, so I guess I will learn to live with it. Hello there, are you getting this issue on Kubuntu or in windows? on macos color selector closes with any action, also ig the cursor leaves the color selection. We implemented a change in cea9741dd7dbb for fixing bug 418668 that probably introduced this bug on win and linux. (In reply to vanyossi from comment #3) > Hello there, are you getting this issue on Kubuntu or in windows? on macos > color selector closes with any action, also ig the cursor leaves the color > selection. > > We implemented a change in cea9741dd7dbb for fixing bug 418668 that probably > introduced this bug on win and linux. It happens in both kubuntu and windows 10. Closing on mouse leaving the popup works fine - it's only not closing on keyboard inputs, that can perform actions (actions are being done, popup stays as it was), and it used to react to any input without performing its action. I think this is a result of these commits: https://invent.kde.org/graphics/krita/-/commit/8621ed93b311bd8035390bb8063609b7b312dd24 https://invent.kde.org/graphics/krita/-/commit/cea9741dd7dbb37d4eaf812e7273d1c143c71217 From what I remember, the first solution broke platforms other than macOS and I suggested to check if the Qt::Tool window flag works for all, but it didn't work for macOS either. Not sure why it was chosen for non-macOS in the end, but I wasn't aware that it changes behavior from the original flags either... Isn't this also fixed by commit 17e6e2841c245aa16eeb000f62f3e5717db7b657 Author: Mathias Wein <lynx.mw+kde@gmail.com> Date: Tue Jun 9 20:04:08 2020 +0200 Remove old workaround for popup palette hiding ? No, commit 17e6e2841c245aa16eeb000f62f3e5717db7b657 was only about (not) signalling when painting with a new color, to build a color history. Shouldn't have any influence on the actual input handling. Git commit 6dc22af666658742b2106ee5c3ac5bf4d25eed9e by Wolthera van Hövell tot Westerflier. Committed on 14/06/2020 at 13:03. Pushed by woltherav into branch 'master'. Use qt::window instead of qt::tool for keyboard events in the popups. The original code used the window hint instead of the tool hint, and that seems to be required to receive keyboard events. M +1 -1 plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp https://invent.kde.org/graphics/krita/commit/6dc22af666658742b2106ee5c3ac5bf4d25eed9e Git commit cb7612c632de3933ea7255f24813ec6da8f67e95 by Wolthera van Hövell tot Westerflier. Committed on 14/06/2020 at 13:06. Pushed by woltherav into branch 'krita/4.3'. Use qt::window instead of qt::tool for keyboard events in the popups. The original code used the window hint instead of the tool hint, and that seems to be required to receive keyboard events. M +1 -1 plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp https://invent.kde.org/graphics/krita/commit/cb7612c632de3933ea7255f24813ec6da8f67e95 Git commit 4211ee84216dafb078539eefebcbfa85521c7fc7 by Wolthera van Hövell tot Westerflier. Committed on 14/06/2020 at 13:08. Pushed by woltherav into branch 'krita/4.3.0'. Use qt::window instead of qt::tool for keyboard events in the popups. The original code used the window hint instead of the tool hint, and that seems to be required to receive keyboard events. M +1 -1 plugins/dockers/advancedcolorselector/kis_color_selector_base.cpp https://invent.kde.org/graphics/krita/commit/4211ee84216dafb078539eefebcbfa85521c7fc7 |