Bug 419246

Summary: Importing .ics holidays calendar doesn't work
Product: [Applications] korganizer Reporter: Christos <aligatorturtle>
Component: import/exportAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: winter
Priority: NOR    
Version First Reported In: 5.13.3   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Holidays in Greece
greece.ics fixed

Description Christos 2020-03-25 23:03:46 UTC 
Created attachment 127017 [details]
Holidays in Greece

SUMMARY

I import an .ics calendar containing holidays, it says it's imported successfully but no holidays show.


STEPS TO REPRODUCE
1. Download the attached .ics file (taken from simple calendar: https://github.com/SimpleMobileTools/Simple-Calendar/tree/master/app/src/main/assets )
2. Import it in korganizer
3. no holidays show

OBSERVED RESULT

no holidays appear & no error messages either

EXPECTED RESULT

holidays should appear

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: KDE neon User Edition
(available in About System)
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
Comment 1 Allen Winter 2020-03-26 20:47:53 UTC 
the ics files you refer to are not valid . or at least not valid enough to make KOrganizer happy.

try loading greece.ics into https://icalendar.org/validator.html and you'll see some problems, especially the PRODID is missing.

You did encounter a known bug that KOrganizer will tell you it successfully loaded a calendar even though it failed.

I'll attach a new greece.ics where I added the PRODID.  You should be able to load this succesfully
Comment 2 Allen Winter 2020-03-26 20:48:29 UTC 
Created attachment 127033 [details]
greece.ics fixed
Comment 3 Allen Winter 2020-03-27 20:29:54 UTC 
ok so this may be a vCalendar format and not an iCalendar formatted file.

I have a patch that might help.  The patch is currently under review.
Comment 4 Christos 2020-03-28 19:25:41 UTC 
(In reply to Allen Winter from comment #3)
> ok so this may be a vCalendar format and not an iCalendar formatted file.
> 
> I have a patch that might help.  The patch is currently under review.

Ahh, didn't realise it was a different kind of formatted calendar, my bad.

Since the not notifying for failure bug is already known should I close this/mark it as a duplicate?

Well, feel free to do whatever, you probably know better.

Thanks a lot for fixing the calendar! (Importing through Korganizer's, add calendar, ical file etc) doesn't work, but opening the file directly and adding it from Korganizer's popup does)
Comment 5 Allen Winter 2020-03-30 21:56:08 UTC 
should be fixed in the next KDE frameworks release

FTR commit 
b3dc1e5d495721797dba0f28ee3eb01555bb5605 in KCalendarCore project