Bug 419200

Summary:	Re-color IBus icon using gsettings to allow readability on dark panels
Product:	[Plasma] plasmashell	Reporter:	ariasuni <aria>
Component:	System Tray widget	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED DOWNSTREAM
Severity:	normal	CC:	mail, materka, nate, uhhadd
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.18.3
Target Milestone:	1.0
Platform:	Other
OS:	Linux
URL:	https://github.com/ibus/ibus/issues/2199
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshot of the systray

Description ariasuni 2020-03-24 21:18:14 UTC

Created attachment 126990 [details]
Screenshot of the systray

SUMMARY
Systray icon of IBus is dark blue and unreadable with a dark themed plasmashell.

STEPS TO REPRODUCE
1. Set Plasma theme to Breeze Dark
2. Launch IBus and open IBus Preferences
3. Go to Input Method tab
4. Add an entry method that’s just a keyboard layout, e.g. English → English (US)


OBSERVED RESULT
IBus icon doesn’t follow the color of the panel theme.


EXPECTED RESULT
IBus icon follow the color of the panel theme. The color is configurable via gsettings (e.g. `gsettings set org.freedesktop.ibus.panel xkb-icon-rgba '#eff0f1'`).


SOFTWARE/OS VERSIONS
Arch Linux
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
Bug I opened for IBus: https://github.com/ibus/ibus/issues/2199

One problem I can see is that it will change the color of the icon for IBus regardless of the environment it is launched in, but that’s already what’s done for GTK so it may not be a blocker.

I guess the change needs to be done at the start of the plasma session because it could be the first time Plasma is launched, or the first time IBus is available and the setting can be changed.

Comment 1 Mikhail Zolotukhin 2020-04-15 12:00:01 UTC

It is possible to sync color of that icon with current color scheme in system settings. May be it is also possible to sync with plasma theme colors, if plasma theme does not rely on color scheme from system settings.

However, it seems like the setting you're referring to is specific to a particular application, but not the GTK applications family as the whole. Therefore what I proposed above is a workaround for a single particular application and therefore I am not in a favor to make this change. The problem can be solved, if the application itself used some universal method to store the color of icon in tray with other GTK applications.

Comment 2 Nate Graham 2020-04-15 14:14:47 UTC

Is there in fact a standardized way for GTK apps to re-color their system tray icons that IBus should conform to? I'm just trying to get a sense of whether this is something they can feasible fix, or whether we'll need to do it.

Comment 3 Konrad Materka 2020-10-23 15:16:53 UTC

This is not a bug in Plasma. Application uses non-standard icon rendering, we can't implement complex workaround just for one application.

Comment 4 Nate Graham 2020-10-23 18:52:27 UTC

From the downstream bug report:

You could set the color with gsettings command:

% gsettings get org.freedesktop.ibus.panel xkb-icon-rgba
'#415099'


So perhaps we could have the kded gtk integration stuff perform this action? Mikhail, what do you think?