Bug 419171

Summary: tagging multiple images at once broken with commit "modified CoreDB to perform recordChangeSet operation on tags"
Product: [Applications] digikam Reporter: Johannes Hirte <johannes.hirte>
Component: Tags-EngineAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: 7.0.0   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: https://invent.kde.org/kde/digikam/commit/e4b99936c71f0894fdd448d1cba3007bc4d44417 Version Fixed/Implemented In: 7.0.0
Sentry Crash Report:

Description Johannes Hirte 2020-03-24 08:21:36 UTC 
SUMMARY
commit d3c4f3f3b7caaf7e9a445aa3081bdf87bf299436
Author: Kartik Ramesh <kartikx2000@gmail.com>
Date:   Sun Mar 15 13:47:40 2020 +0000

    modified CoreDB to perform recordChangeSet operation on tags


breaks tagging multiple images at once. When selecting more than one image, only the last one is modified when adding/removing tags. Reverting this commit fixed it for me.

Tested with latest git revision.

STEPS TO REPRODUCE
1. select multiple images
2. add or remove tags


OBSERVED RESULT

Only the last selected image is getting tags added/removed.

EXPECTED RESULT

All selected images are getting tags added/removed.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gentoo Linux
(available in About System)
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Comment 1 Maik Qualmann 2020-03-24 18:50:01 UTC 
Git commit e4b99936c71f0894fdd448d1cba3007bc4d44417 by Maik Qualmann.
Committed on 24/03/2020 at 18:48.
Pushed by mqualmann into branch 'master'.

add new TagChangeset to update only
Related: bug 406586
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +1    -0    core/libs/album/manager/albummanager_talbum.cpp
M  +2    -2    core/libs/database/coredb/coredb.cpp
M  +1    -0    core/libs/database/coredb/coredbchangesets.h

https://invent.kde.org/kde/digikam/commit/e4b99936c71f0894fdd448d1cba3007bc4d44417
Comment 2 Maik Qualmann 2020-03-24 19:26:32 UTC 
Git commit aaf21ef57359e4ffa710e093cac781fb2082e265 by Maik Qualmann.
Committed on 24/03/2020 at 19:25.
Pushed by mqualmann into branch 'master'.

start the timer new for fewer events

M  +6    -1    core/libs/album/manager/albummanager_talbum.cpp

https://invent.kde.org/kde/digikam/commit/aaf21ef57359e4ffa710e093cac781fb2082e265