Summary: | "Duplicate item" doesn't work with Spanish locale | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Antonio Rojas <arojas> |
Component: | general | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kfm-devel, nate |
Priority: | NOR | ||
Version: | 20.03.80 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/dolphin/9b82b08fb18724662c69ed288b1a36a215548539 | Version Fixed In: | 20.04.0 |
Sentry Crash Report: |
Description
Antonio Rojas
2020-03-21 11:53:42 UTC
Oops, sorry about that. Here's a patch to fix it on the Dolphin side: https://phabricator.kde.org/D28227 Git commit 9b82b08fb18724662c69ed288b1a36a215548539 by Nate Graham. Committed on 05/04/2020 at 22:48. Pushed by ngraham into branch 'release/20.04'. Use same logic for "no extension" case with Duplicate feature Summary: In the "no extension" case, we weren't separating out the path and the original filename, breaking the feature for languages where the word "copy" would be at the beginning of the filename, not after it (e.g. "copia de foo" in Spanish, and similar in other romance languages). This patch fixes that by separating the original path and filename in the no extension case as is done for the other case, which should solve the issue. FIXED-IN: 20.04.0 Test Plan: No changes in English; should fix the issue in Spanish once new translations are done (see https://bugs.kde.org/show_bug.cgi?id=419070 for details) Reviewers: #dolphin, elvisangelaccio, arojas, meven, pino, #localization Reviewed By: #dolphin, elvisangelaccio Subscribers: aacid, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D28227 M +4 -3 src/views/dolphinview.cpp https://commits.kde.org/dolphin/9b82b08fb18724662c69ed288b1a36a215548539 |