Bug 419046

Summary: Too easy to delete icon themes by accident
Product: [Applications] systemsettings Reporter: G_v_I <riddervancocagne>
Component: kcm_iconsAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: nate
Priority: NOR    
Version: 5.18.3   
Target Milestone: ---   
Platform: Kubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description G_v_I 2020-03-20 13:11:49 UTC 
SUMMARY


STEPS TO REPRODUCE
1. Open System Settings > Icons.
2. Click on the bottom right corner of the image representing an icon theme (where the 'waste' button is located).
3. Click apply.

OBSERVED RESULT

The icon theme is completely removed from the system. 

EXPECTED RESULT

The icon theme is either put in the wastebin OR the user is asked for conformation that they want to delete this icon theme.

It is very easy to accidentally click the 'delete' button if one actually wants to apply a theme, especially since the delete button is hidden until the user hovers over it. Therefore, it would be best if additional safeguards were in place.


SOFTWARE/OS VERSIONS

Linux/KDE Plasma: Kubuntu 19.10 with KDE Backports enabled.
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.67.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2020-04-15 15:27:20 UTC 
That's the way it already works: when you click on the trash icon, the icon theme is not actually deleted; it is simply queued up for deletion and you need to click the Apply button to apply the change and delete the icon theme.
Comment 2 G_v_I 2020-05-04 18:30:48 UTC 
Not really. 

I have recently been working on an icon theme, switching to another theme and back again to reload my own theme and see whether, and how, the changes I made worked out. Especially if you are working quickly, it is very easy to click on 'delete' and then 'apply' because the little wastebin in the bottom right corner is normally hidden and you are moreover never asked for confirmation that you want to remove this theme.  

This would not be all that much of a problem if the theme were not removed permanently, but was put in the wastebin instead.
Comment 3 Nate Graham 2020-05-04 19:20:27 UTC 
When you accidentally click on the trash icon, the to-be-deleted grid item lightens as well, providing a visual clue.

I suppose we could add an "are you sure you want to delete this thing" warning, but that just seems like overkill to have both a two-step deletion process as well as a warning. If we did that, you'd quickly get annoyed by it and click the "don't bug me again" checkbox on the warning message, so it wouldn't actually be helpful when you needed it.
Comment 4 G_v_I 2020-05-04 19:34:48 UTC 
I do see your point, but I still don't think hiding a delete button and then making the deletion permanent is a very good idea. 

The hint will be sufficient in the majority of cases, but if you're working quickly and not  focusing on subtle visual cues the result can be quite frustrating - unnecessarily so, I think.
Comment 5 G_v_I 2020-05-04 19:35:51 UTC 
(In reply to G_v_I from comment #4)
> I do see your point, but I still don't think hiding a delete button and then
> making the deletion permanent is a very good idea. 
> 
> The hint will be sufficient in the majority of cases, but if you're working
> quickly and not  focusing on subtle visual cues the result can be quite
> frustrating - unnecessarily so, I think.

...I mean initially hiding, of course.