Bug 419010

Summary: Dolphin can't copy files due to incorrect free space check
Product: [Frameworks and Libraries] frameworks-kio Reporter: Sergey "GrayFace" Rozhenko <sergroj>
Component: generalAssignee: David Faure <faure>
Status: CONFIRMED ---    
Severity: normal CC: a.samirh78, kdelibs-bugs, kfm-devel
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Kubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Sergey "GrayFace" Rozhenko 2020-03-19 09:27:28 UTC 
SUMMARY
I'm copying about 1TB of files onto about 1TB HDD. Over half of them were copied before. If I try to copy them through Dolphin now, it says there's not enough space, because it doesn't subtract the files already copied from space required.

STEPS TO REPRODUCE
1. Take any medium and a folder with files that would pack it full.
2. Copy half of files, stop the operation.
3. Copy whole folder again to the same location.

OBSERVED RESULT
Copying would fail with 'not enough space' error.

EXPECTED RESULT
Copying success with me being asked to overwrite or skip already copied files.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Kubuntu 19.10 (64 bit)
(available in About System)
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
Comment 1 Sergey "GrayFace" Rozhenko 2020-03-19 09:30:10 UTC 
It not subtracting size of already copied files is just my guess, because it fails before even asking if I want to overwrite them.
Comment 2 Christoph Feck 2020-04-09 19:03:06 UTC 
Without an answer to the overwrite confirmation dialog, it could take the maximum size of source and destination file, and subtract the size of the destination file.
Comment 3 Ahmad Samir 2020-05-05 17:28:31 UTC 
The code sees a "source", in this case one big folder, it computes the free space at the "destination"; if the free space at the destination is less than the size of "source" it stops.

AFAICT, currently the code can't tell that half of those files have already been copied before.
Comment 4 David Faure 2020-05-10 13:25:24 UTC 
The solution is for the "not enough space" error to be turned into a dialog that gives the choice to the user, no?
The usual messagebox with "Continue / Cancel" buttons.

This would also cover the use case of "yeah I know, I'll make some room at destination while the very slow copy happens".